@Michalol94Submitted 3 months ago
Kévin Waeterinckx
@kwaeterinckxAll comments
- @kwaeterinckxPosted 3 months ago
Impressive ! Pixel perfect :) Nice work. It seems that your Github link is not working. I can't look into your code for this project. If you used grid, then maybe you can add a template in between the desktop and the mobile version, working with 2 or 3 columns and puzzling the different testimonials like the desktop version. Keep up the good work !
Marked as helpful1 - @ali-ayadSubmitted 3 months ago@kwaeterinckxPosted 3 months ago
Nice work. The responsiveness on mobile and desktop works fine. But in between, in table mode, the cards are positioned in a strange way. Maybe add some styling for medium sized screens.
The design looks good, just some adjustments to make on the font sizes and weights for the titles. The css contains a lot of literal values. You can try to use custom properties instead (it's like variables but for css). There are a lot of resources to learn it on YT for example. Definitively worth to learn, it will help you a lot for responsiveness.
Keep up the great work !
1 - @Danish030Submitted 3 months ago@kwaeterinckxPosted 3 months ago
Very close, great work! The only thing is the title. It has to be in Fraunces too. Responsiveness works fine. The button seems smaller in height on the desktop version.
Your css is well constructed, including custom props and default reset. Keep up the good work!
Marked as helpful0 - @qlubackSubmitted 3 months ago@kwaeterinckxPosted 3 months ago
Nice! Very well written code. Semantic HTML, CSS is perfect. If I had to say something, I would suggest a bigger margin-block on the main. It is originally set at 128px. But the rest is good.
Keep up the good work!
Marked as helpful0 - @magicDGSSubmitted 3 months ago@kwaeterinckxPosted 3 months ago
Nice work!
Your CSS is very good, using custom properties. Semantic HTML, what do I need to say more?
Keep up the great work!
0 - @MargumedoSubmitted 3 months ago@kwaeterinckxPosted 3 months ago
Nice work!
Just missing the hover effect on the title. There are some other small styling corrections to make, the label color and the title size.
Keep up the good work!
0 - @MuhReski287Submitted 3 months ago@kwaeterinckxPosted 3 months ago
Nice work! Very close. Just a small remark on the responsiveness. On smaller screens (320px wide), a small resize can be applied. You can challenge yourself by trying flexbox :) And a suggestion; try to keep your css code appart from your html. Create .css files and link them to your html page. It will be easier to manage once you will reach more and more lines on bigger projects. Keep up the good work!
Marked as helpful0
