P
Katlego Makama• 40
@KatMahn
Submitted
karlo
@ktorres63
All comments
- karlo• 90
@ktorres63
Posted
- You forgot to add the outfit font to your html file
- you forgot to center it horizontally, since you use the tag section you can center it using margin-left: auto; and margin right:auto
- If you notice the example has a small margin-left at the beginning of each li element, so I would just add li{ margin-left:24px;} -I think you should delete the final comment in the index.html since it doesn't contribute anything
0 @RapidSolutions3535
Submitted
What are you most proud of, and what would you do differently next time?
Proud that it looks kinda simillar, less research and more work.
What challenges did you encounter, and how did you overcome them?
Html, I dont use it very often. I search a lot in the web to be able to do it.
What specific areas of your project would you like help with?
Not sure yet, kinda get the feeling for it.
karlo• 90@ktorres63
Posted
- This is correct but it would be easier to work with a separate CSS file.
- If you have problems with the sizes, paddings or margins, you can check the figma file there are the sizes
- If you use display: flex you can use gap:<a number>px to give spaces between elements
0- Juan Carlos Moreno J• 120
@juancmdev
Submitted
What are you most proud of, and what would you do differently next time?
I have learned a lot.
What challenges did you encounter, and how did you overcome them?
I feel comfortable with this challenge
What specific areas of your project would you like help with?
Semantic HTML, reviews about my code and how can I improve.
karlo• 90@ktorres63
Posted
- I find it interesting how you used display:none to hide the attribution class
- If you use display:flex you can use gap: <a number>px to give space between each element
- You can use the transition property to smooth the transition between 'a' and 'a:hover'.
Marked as helpful
1 - 123dakalo• 50
@123dakalo
Submitted
What are you most proud of, and what would you do differently next time?
I'm learning how to be creative
What challenges did you encounter, and how did you overcome them?
I was struggling with putting learning but figured it out by adding a div
What specific areas of your project would you like help with?
The learning part from the design if the is a better method than adding a div and a span
karlo• 90@ktorres63
Posted
- I find the use of the tag section interesting, I didn't know about it.
- In the part of the img tag you forgot to put a description
- When I want to see your website on Github Pages, only the markdown appears, I'm not sure why but I suspect it's because you named the html file as blog.html when it should be index.html.
- In a few lines of code you achieve the objective, that seems excellent to me.
Marked as helpful
1 - danielss2990• 10
@danielss2990
Submitted
karlo• 90@ktorres63
Posted
very good design, just missing a little top margin, otherwise it seems excellent to me
0
