Skip to content
OverviewSolutions
11
Comments
13
Solomon Ekrebe
@krebeDev

All comments

  • Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    I appreciate your feedback @mattstuddert.

    As a beginner, working with React was quite tough, but exciting nonetheless.

    • I didn't know assigning e.currentTarget.id to userChoice.name will directly mutate the userChoice object in state, because I started off by cloning userChoice and houseChoice like so:
    handlePick = (e) => {
    const userChoice = {...this.state.userChoice};
    const houseChoice = {...this.state.houseChoice};

    // Other code lines go here
}

    Do I have to clone/setState for each key : value pair in this instance?

    I've started learning about hooks, and definitely will apply them once I get the hang of it.

    • On the identical components, I'll refactor my code as you suggested. I just noticed the same repetitive pattern in my Starter component too. I'll fix them.
    0
  • Solomon Ekrebe•610
    @krebeDevSubmitted almost 5 years ago

    I've had to use two empty divs to display the curly background patterns in the intro section. I feel this approach is not effective. Any ideas on a better way to achieve the design that's in line with best design practices? You're welcome.

    Insure landing page with - Vanilla JS, HTML and CSS

    2
    Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    Thanks for the feedback @mattstuddert. I didn't know I could use url() as content for ::before and ::after pseudo-elements until today. I'll definitely give it a try.

    0
  • Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    The design is great on desktop/large screens. I suggest you include media queries by introducing different breakpoints/CSS rules to make it responsive in smaller viewports.

    1
  • Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    I see nothing missing :). Great job you've done here!

    1
  • faheem102•38
    @faheem102Submitted almost 5 years ago

    hej this is my solution as a beginner. i do not know how to fill logo color into white. can some one please explain to me with some easy method to it. thank you

    fylo landing page

    1
    Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    Hey @faheem102,

    Great work on this challenge. To change the logo colour, one way is to load it directly as svg element instead of using img tag. Then change the fill color of the svg to white inside the svg style definition.

    1
  • vongphakdy•140
    @vongphakdySubmitted almost 5 years ago

    I have 2 error cases for email validation; the first is an empty field, second is an invalid email address. Both cases should activate the error message and icon, however only this only applies to the first case. When entering an invalid input, the form reveals a prompt rather than my coded error message/icon. I'm new to JS so I appreciate any input

    Email validation with VanillaJS, SCSS, HTML

    2
    Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    Hello @vongphakdy, Great job on this challenge. Your error message is not being activated because HTML5 form comes with built-in form validation. To deactivate this default behaviour and ensure your JavaScript code is triggered, add a novalidate attribute on the form element. In your case, your code will be like so <form novalidate class="main-form">.

    Also, your JS form validation code should be enhanced to accommodate other use cases. For example, if a user enters a correct email after a wrong attempt, the error message should be discarded.

    2
  • Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    Wow!!! Great work Daniel. I personally have been battling with this challenge for some days now. Your code is clean and comprehensible. I have no improvements to recommend. Great job.

    1
  • Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    I checked in. My observations are the same issues being addressed by @Mattstuddert, particularly the breakpoints. You can improve in those areas.

    1
  • Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    I also noticed the link to your live site is broken.

    0
  • Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    Hi Chadrack, great work! Do check your page's Report and fix the accessibility and validation issues. I can help if you need more clarifications on these.

    1
  • Matěj Kubíček•130
    @matejkubicekSubmitted almost 5 years ago

    I'm newbie in front-end development and I know, that my workflow is little bit complicated for this small project, but I trying to learn frontend technologies and tools more comprehensively.

    Please leave me a feedback about my code and used workflow. Thx

    Four card - mobile first, responsive

    2
    Solomon Ekrebe•610
    @krebeDevPosted almost 5 years ago

    Looks good. But do check the HTML validation report on your solution. The roles you specified in your markup are unnecessary since you already used the appropriate HTML5 semantic elements.

    1