Skip to content
OverviewSolutions
2
Comments
4
Tristan Sean Paul Perfecto Cinco
@kolehiyolo

All comments

  • Tristan Sean Paul Perfecto Cinco•45
    @kolehiyoloPosted almost 4 years ago

    Yo dude! Absolute noob here so take my suggestion with a massive grain of salt. What I would suggest is instead of setting the circles as background images, just create divs for each of the circles. Then manipulate their positions that way.

    I also noticed that the card didn't have a shadow, but yeah overall nice job! Let's hang sometime

    1
  • Michal Rogozinski•50
    @rogozinskiSubmitted almost 4 years ago

    Please rate my solution for this challenge and share your thoughts. If there's something I could do better don't hesitate to mention it. Personally, I feel like my CSS structure could be more organized

    Profile card component

    1
    Tristan Sean Paul Perfecto Cinco•45
    @kolehiyoloPosted almost 4 years ago

    Yo dude! I'm a newbie so take all my suggestions with a massive grain of salt. But here's what I noticed:

    1. I didn't think your card has a shadow, although after checking the code, it actually was there, so perhaps getting it thickened would be cool
    2. The "likes" text is not center-aligned

    After looking at your CSS, I can't really find any issues other than the indents lol. That being said, I am no pro so what do I know. Either way, cool job dude! Let's hang sometime

    0
  • Tristan Sean Paul Perfecto Cinco•45
    @kolehiyoloPosted almost 4 years ago

    Dude, we on the same boat. Newbie here, too. Here are my observations:

    1. The profile image is supposed to have a white border around it
    2. The statistics text is too big
    3. The "likes" is not centered
    4. I might be wrong, but I don't think the card has a shadow, which it should

    That being said, I checked your code, and I learned a lot myself! I didn't know that I could just reference the svg's as images. I didn't know that you can just use the card svg as a background-img of the card div itself. And yeah I also didn't know about a lot of the attributes you used, such as flex. But yeah dude great job! Let's hang sometime. Peace

    0
  • Tristan Sean Paul Perfecto Cinco•45
    @kolehiyoloPosted almost 4 years ago

    the best suggestion I can give you is position:absolute. this is the one that is guaranteed to always keep your content in the center of the page.

    .card{ position:absolute; top:50%; left:50%; transform:translate(-50%,-50%); }

    checkout this video for more info on the position attribute: https://www.youtube.com/watch?v=P6UgYq3J3Qs

    0