All comments

• 

  Felipe Stefani•330

  @felipestefaniSubmitted over 2 years ago

  Hey, folks! How are you?

  I'm looking for you opinion on what I can improve the project. I used only basic HTML, CSS and Vanilla. To make requisition use promises.

  Could you point some improvements that could've be done?

  Thanks all to you to the collaboration!!!

  

  Responsive and interactive page using HTML, CSS and Vanilla

  2

  60
  

  vincent•120

  @kikiklangPosted over 2 years ago

  Hey, some few tips. I just made this challenge and found a way to get this quotes right.

  .advice-sentence::before { content: "\201C"; } .advice-sentence::after { content: "\201D"; }.

  Also, you wrote a function in JS to get the divider svg right. You can avoid that , simply do the following in your HTML

  <picture> <source media="(max-width: 576px)" srcset="./pattern-divider-mobile.svg" /> <img class="advice-divider" src="./pattern-divider-desktop.svg" alt="a divider" /> </picture>

  overall, your design is great, however your javascript could be simpler. gg.

  Marked as helpful

  1

  This comment has received 1 replyShow