@GladysiakSebastian
Submitted
@khanwelcomes
@GladysiakSebastian
Submitted
@khanwelcomes
Posted
Semantic HTML: The use of <article>, <header>, and <ul> is great for structure and clarity. The div with class "card__bio" could be replaced with a <p> element, which is more semantically meaningful for a block of text like a bio.
Accessibility: The alt attribute for the profile image ("Jessica profile image") is present, which is essential for screen readers. Proper use of list structure (<ul> and <li>) for the social links is a good choice for accessibility.
@hugopfe
Submitted
What are you most proud of, and what would you do differently next time?
I'm glad to use unified values with CSS variables for spacing, font sizes, and colors
What challenges did you encounter, and how did you overcome them?
To unify the spacing between elements, I have used a class margin-top
for all elements
@khanwelcomes
Posted
The structure and content is on point. you could match the exact dimensions between elements using figma reference.
@jvondungen
Submitted
What are you most proud of, and what would you do differently next time?
Most proud that I figured out how to use Github, create a webpage and get the thing to look something like the sample. Next time I would start with the mobile view and work from there using either Flexbox or Grid (still learning both).
What challenges did you encounter, and how did you overcome them?
I had a lot of difficulty learning how to push files to Github and even get it to work in the first place. Somehow I figured things out with some querying on the web. Also had a lot of trouble getting the spacing to work. I managed this mostly through trial and error, which was very time consuming. Finally had difficulty getting the page to be responsive. I used @media queries, which improved, but didn't totally get it to be responsive. (some sizes didn't look right).
What specific areas of your project would you like help with?
Learning how to get it to be responsive.
@khanwelcomes
Posted
Hi, Overall the result is job done. However, to match the exact spacing between elements and fonts try using the figma design for exact details.
Marked as helpful