Skip to content
OverviewSolutions
4
Comments
2
khal45
@khal45

All comments

  • contrebasses•50
    @contrebassesSubmitted 24 days ago
    What are you most proud of, and what would you do differently next time?

    I just think it looks good ¯\__(ツ)_/¯

    What challenges did you encounter, and how did you overcome them?

    I had a hard time finding an elegant way to make the entire card accessible through keyboard-only navigation. I'll keep improving on this solution.

    What specific areas of your project would you like help with?

    I'd like to discuss accessible solutions with other devs.

    Blog Preview Card

    1
    khal45•60
    @khal45Posted 24 days ago

    Hey there! Great job completing this challenge. Overall you did well but your solution is not responsive. Conside using media queries to make your solution responsive on various screen sizes. Don't know how to make them responsive yet? No worries there are a lot of resources online that can help you with that. Css tricks is one of my favourite sites for learning css concepts, you should try it.

    Marked as helpful
    0
  • khal45•60
    @khal45Posted 28 days ago

    Hi there!, great job on completing the challenge. Here are some suggestions that could help:

    • The qr-code image isn't rendered on the page. Unfortunately it seems you do not have an images folder which results in a broken image. Ensure your images folder is in your project with the image inside and push to github.
    • Try removing the "./" in your image path. Paths are handled differently in a deployed environment compared to a local one, the "./" could affect the rendering of the image.
    • It's good practice to put the univeral selector: *{css styles here} at the top of your css before other styles.
    • Your container is not properly centered in the mobile version. Try creating a wrapper for the container and use display: flex; justify-content: center; align-items: center; to center the container.
    • Check out these articles to help you better understand when to style elements with a class and when to use an id: CSS Id vs Class ID vs. Class CSS: Which Should You Use?
    0