This project is a little bit customized by me. On the about page instead of a flag, it shows a map created using Leaflet API and some background colour changes in border country buttons. Though this site responds slow. If anyone has other ideas on how it can be customized further will be very helpful. Any feedback on the project is welcome.
Khaizter
@khaizterAll comments
- @yashjangir1Submitted over 2 years ago@khaizterPosted over 2 years ago
Hi, I like how you add the other features, but there are some things that I think need some tweakings.
- The box shadow was too thick or dark, try to use a little transparent color.
- There's no Antartic region
- The theme toggle switch has letter "s" on it. But anyways good job on it.
Marked as helpful1 - @tomhineSubmitted over 2 years ago
A lot of my recent projects were built with Vue, so it's been fun getting back to using React. Could probably add some animations to this, although I might just do that with the next project.
Any and all criticism would be really helpful!
@khaizterPosted over 2 years agoI suggest using repeat(auto-fill, minmax(minimum-size, 1fr)) in the grid template columns this will make your grid become responsive with less media queries. As it automatically fills up another column if there's a space available.
0 - @Andrewthe13thSubmitted over 2 years ago
How to add the pill svg to the background to this website the most optimal way? My method seemed to be too hardcoded. Also are there any ways to change the color of svg without using inline svg in the html?
@khaizterPosted over 2 years agoyou can change the color of svg by using the filter property here check this out https://stackoverflow.com/questions/22252472/how-to-change-the-color-of-an-svg-element
Marked as helpful0 - @trafargarlawSubmitted over 2 years ago
- first experience with scss.
- not so sure of the structure of my scss file, but sure of the lack of semantic html.
- Would be interested into knowing more about how to structure the scss file
@khaizterPosted over 2 years agoI suggest to try the 7-1 patterns on SASS. they have a guidelines for it in SASS guidelines you might want to check it out.
0 - @mackievaSubmitted over 2 years ago
This was fun, I wanted to take a break from little js projects and I haven't built out a landing page in a couple months.
- The biggest thing I'm curious about is how others handled the images. I wanted to practice using srcset, so I made the top and bottom four square images use object-fit in the grid area. Then for the cherries and orange that had text I just made them background images.
- I'm looking forward to see if others used any animations with the mobile menu. I'll use basic transitions (like this one sliding in), but complex animations not so much and I'll like to use more. I did put a little bounce on the arrow though because why not.
- The other thing is naming elements. I'll use something like BEM but it's usually sloppy and could easily be improved. I've never worked with other developers on projects so it's led to some bad habits.
ok, time to move on to the next thing
@khaizterPosted over 2 years agoWhat I did in the image was change the src of img tag on css by content : url(), i didn't know the srcset maybe I will try it on next projects. Anyway good solution!
0