Skip to content
OverviewSolutions
15
Comments
2
Raymond Fajiculay
@keyztrokee

All comments

  • Raymond Fajiculay•230
    @keyztrokeePosted about 2 years ago

    Hi Mateus Duarte great start, but I have few thing you might want to consider

    1. Instead of putting paddings and margin on the right corner you can use the padding on the text1 div instead.

    2. Consider making a mobile view of the card with media query and flexbox

    Media Query https://css-tricks.com/a-complete-guide-to-css-media-queries/

    Flexbox https://css-tricks.com/snippets/css/a-guide-to-flexbox/

    3.Add padding on your button

    It will improve a lot your work I hope it helps

    Marked as helpful
    0
  • Rico•370
    @ShuliiiSubmitted about 2 years ago

    hi it's my first project. Any feedback or any kind of improvements that I can make will be very much appreciated.

    QR Code Component

    3
    Raymond Fajiculay•230
    @keyztrokeePosted about 2 years ago

    Hi, Rico! Very cool solution, it really looks great :)

    I noticed three things that you might want to consider:

    1. Change the h1 color to var(--clr-dark-blue) because it is not black.

    2.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    3.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    Other than that, really great job! :)

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1