For responsiveness is it better to scale the SVG main title graphic based on say the viewport width or just use breakpoints and have pixel/rem values? Personally I chose the latter. Other than that would be happy to hear any further feedback!
Jakub Krwawicz
@kerminekAll comments
- @webguy83Submitted over 2 years ago@kerminekPosted over 2 years ago
Great solution. Nothing to add. Nice, responsive mobile version. And answering your question: well, it depends... In your case, scaling it with viewport units could work. But in my project, where i've used precise animations, i prefer a solid width and breakpoints. I would like you to see my solution too :)
1 - @AnaesthCodeSubmitted over 2 years ago
This was a very fun challenge. Probably lots of room for improvement. Grateful for any feedback! Cheers
@kerminekPosted over 2 years agoI would delete this transition on toggling dark mode. I assume that there is a transition for purpose of scaling this country tile. You can fix this using transition-property - in this case: transition-property: transform;. The other thing is Country Page height. On my 13inch macbook, page is scrollable, even though it could easily fit. Hope you check my profile and leave some feedback too :)
Marked as helpful1 - @sandlerzSubmitted over 2 years ago
I'm happy to do this project my first project at level of advanced
Please comment with any feedback or suggestions, I appreciated a lot
happy coding!
@kerminekPosted over 2 years agoHi! Thats very great project. I would recommend you to not to fetch data all the times, because you've already got it. Save your data using context, then if you want to get specific country data, just search it. Search bar is not only looking for start of the first string, which is great. And i feel like dark/light mode transition looks just bad, it's better when it's instant. Would appreciate if you would see mine solution. Have a nice day :)
Marked as helpful1 - @webguy83Submitted over 2 years ago
Angular Material custom theming was definitely an experience. Not sure my way was the best approach but if you search my _palette.scss file you can take a look and it gets the job done. Love any feedback.
All the HTML issues in the Generated report are because Angular injects all those custom attributes.
@kerminekPosted over 2 years agoLooks really great! I wanted to do this border countries component with full names, but i was too lazy for that :D Also wanted this animation on hover on country tile, but i've used react-virtualized list to make searching smooth, and that's unfortunately is blocking scale() feature. I also feel like searching feature is working much better in mobile. Anyway, great project. Would appreciate if you would see mine :)
1 - @AllanguiSubmitted over 2 years ago
Hello guys !
I am very happy to publish that challenge it takes me some times of pleasure :D It would be very nice to get feedback if they are some issues or adjustement to do !
I did my best for the design but that's not easy to be pixel-perfect without figma Using Vue3 + Vite , and with bonus localStorage
Thank you for visiting :D
@kerminekPosted over 2 years agoVery nice! It lack's some styling but js was already tough enough. I made similar solution but using react and redux :)
1 - @catherineisonlineSubmitted almost 3 years ago
Hello, Frontend Mentor community! This is my solution to the URL shortening API landing page.
I appreciate all the feedback you left that helped me to improve this project. I fixed the issues I had previously and added new features per your recommendation.
I have done this project a while ago however if you are here and have any feedback, tips, or ideas to share, I will be more than glad to hear them out!
Thanks
@kerminekPosted almost 3 years agoHi, one image makes your page wider than we want it to be. Solve it using "overflow: hidden" on main container of the page. Also, if you want to keep data after refresh try to make it using cookies or simply "localstorage" :)
0 - @ANSH4195Submitted almost 3 years ago
- How can the SASS code I wrote be further split?
- One feature I was not able to implement was the hover on the ellipsis button alongside title without hovering on the bg. Do help me implement a solution to this.
@kerminekPosted almost 3 years agoHi, in answer to your second question i've found this: https://stackoverflow.com/questions/40966977/how-do-i-hover-over-a-child-element-without-hovering-over-the-parent-in-css , so there's no easy way to handle this.
What i see, is that first box in mobile view is not looking correct. Also those buttons are way too big, so when you hover next to them, they are changing colors (Try to use "width: fit-content").
Marked as helpful1 - @jainish011Submitted almost 3 years ago@kerminekPosted almost 3 years ago
- App is not centered.
- Adjust font weight and font size in this big box on the left.
- Dots are not changing color on hover(Use "fill" property not on the svg, but on path element inside svg).
- You forgot mobile page.
0 - @GozOnTheCodeSubmitted almost 3 years ago@kerminekPosted almost 3 years ago
- Dots are not changing color on hover(If i remember correctly, you should use "fill" not on a svg but instead on a "path" inside svg ).
- Whole app is not centered(Just use flexbox on the main container, then justify-content:center, align-items:center ).
- Colored background is overlaying the dark one(zoom in, it's visible especially on the bottom)(Try to use overflow:hidden).
- Mobile version is not accurate at all.
- You can improve spacings and font size on left dark box.
0