Kenny Ng
@kennylun123All comments
- @Jake-OzSubmitted 10 months ago@kennylun123Posted 7 months ago
It is a very good use case of using NextJS server side component. I took a reference from your fetching too.
One question for me, how do you manage to scroll to top when every time we go into detail page? Did you do something to keep this behaviour?
0 - @Mazz100Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I achieved the render of
DropDownMenu
andDialog
using ReactPortal
and referenced states withuseContext
hook.I could not implement full interaction of dialog and dropdown I think in future projects I will consider using 3rd-party to assist in creating a proper dialog with correct accessibility.
What challenges did you encounter, and how did you overcome them?useContext
was really useful for minimizing prop pass drilling but depending on a bigger project scope I could use 3rd-party plugin to store and manage states.The biggest challenge I kept facing was to properly pass the correct array value of cards and when to and not to recreate a new
.map
copy of it.I learned how to work with map in states and compare the original cards object with a copy and check for the intended conditionals.
- @FridaWaldtSubmitted about 1 year ago
One of the questions I had for this project was if there's a better way to place the images in the banners than I did by using #id for each and adding a background-image? I'd love any feedback really regarding best practices in any capacity, I'm here to learn and improve! Thank you all in advice for being so kind to review my work.
@kennylun123Posted about 1 year agoHi Frida,
I hope you're doing well! I wanted to take a moment to congratulate you on completing the coding challenge. Great job! 😊
I also wanted to provide some feedback on your code:
Imagine that each of your
category-card
is a reusable component. Inside of it you just need one div forcategory-card-stats
. And you could set background image tocategory-card
(parent container). You could either set the background using in-line style or assign anid
to each component and use CSS selector as you did. After that you can finish thecategory-card-stats
.Keep up the great work! I'm looking forward to seeing what you'll create next.
Best regards,
Kenny
Marked as helpful0 - @kennylun123Submitted about 1 year ago
Hi everyone, this is my solution of Responsive Space-Tourism-Website using NextJS(App Router). I managed to complete this challenge in one week. I really enjoy the way to handle routes with NextJS (App Router) by just creating a new directory and page.js. Considered a better user experience. I would like to add fade-in animation to components rendering.
Any comment would be appreciated. Thanks for your help!! :D
@kennylun123Posted about 1 year agoHi everyone, I've added page transition effects to have a smoother experience. By using a React animation library called
framer-motion
. I hope you enjoy it!*If you are using NextJS 13 like mine, please note that this library is compatible on client component only.
0 - @FrontendBy-GJSubmitted over 1 year ago
I would appreciate any feedback on my solution. What do you think of my approach and implementation? Thank you in advance for your input!
@kennylun123Posted over 1 year agoHi Garcia, do you prefer Vite or CRA? I've seen the original docs for CRA has been replaced by NextJS / Remix etc. I'm considering what should I start with on next challenge.
https://react.dev/learn/start-a-new-react-project
0 - @antben59Submitted over 1 year ago
I had difficulties with the responsive of the site, especially the mobile version. I didn't know if i only had to do with 375px width screen or all the width screen from 1440px to 375px. I finally decided to do it from 1440 to 375px.
Do you have any advice for me for my future challenges for the responsive? Especially on the screen sizes that i must focus on, or websites that can help me to improve it.
Thanks !
@kennylun123Posted over 1 year agoCongratulation on completing the challenge! It's always good to finish the mobile version first then work on the desktop or tablet version using media query. Also I saw that two of the flex item are reversed in between 500px ~ 700px width.
@media screen and (max-width: 700px) and (min-width: 500px) .newsletter-container { flex-direction: column; // Delete this should work. ** justify-content: center; }
0 - @iago-monteirogSubmitted over 1 year ago
Could you please give me tips on how to optimize image sizes with media? I believe I am making a mistake in executing these dimensions.
@kennylun123Posted over 1 year agoHi Iago, you can try <picture> tag in HTML which can load different image url in different resolution.
This is my case,
<picture> <source media="(min-width: 40em)" srcset="images/image-product-desktop.jpg"> <img src="images/image-product-mobile.jpg" alt="Perfume_image"/> </picture>
Marked as helpful0