Skip to content
OverviewSolutions
3
Comments
3
Keethesh
@keethesh

All comments

  • Daniel Tving•220
    @dantviSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    Completing the challenge and getting everything up and running.

    What challenges did you encounter, and how did you overcome them?

    I had some problems with getting the links to work as intended. At first, I had an unordered list with list items containing the a tags. The problem that occurred was that the user needed to press on the text inside of the buttons for the links to work. If the user pressed outside of the text but still within the button, the link would not work. I removed the a tag completely and made an event listener that listened for the onclick event. Then in js I created functions that would take the user to the correct webpage. Now that I think of it, I could probably make a function that takes a parameter (each webpage) and then use a template string to open the correct webpage. This would make it one function instead of five different ones.

    What specific areas of your project would you like help with?

    Any feedback would be appreciated.

    Social links profile

    1
    Keethesh•50
    @keetheshPosted 3 months ago

    Great work! Maybe try to use a bottom margin to lower the location? Also it looks a bit on the side, try finding a way to center it. The weight of the bio as well is not exactly the same. Some minor changes to the spacing between some elements should also make it more identical than it already is!

    0
  • Keethesh•50
    @keetheshPosted 3 months ago

    Pretty close! Maybe try using padding to make it larger?

    Marked as helpful
    1
  • Keethesh•50
    @keetheshPosted 3 months ago

    Hey there! That's a nice first try! Here are some things that might help:

    • Try using padding to wrap your text, since padding add space on the "outside" of the element.
    • Loading your CSS styles from a .css file is usually recommended over directly putting all your styles in the HTML
    • Use height: 100vh or width: 100vw to fill the entire body with your background. Don't forget to remove the padding and margins on body with
    body {
    margin: 0;
    padding: 0;
}
    0