Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @RadaidehDaniel

    Submitted

    What are you most proud of, and what would you do differently next time?

    Everything.

    What challenges did you encounter, and how did you overcome them?

    I build it without planning. I write the logic on the fly. Next time, I will consider planning the app structure and logic before touching the keyboard.

    What specific areas of your project would you like help with?

    none.

    P
    kayan 630

    @kayan2004

    Posted

    great job! However for the next time, try to organize your javascript code better.

    Marked as helpful

    1
  • P

    @prem-kumart

    Submitted

    What are you most proud of, and what would you do differently next time?

    • learned to overwrite the default styles of checkboxes and slider.

    What challenges did you encounter, and how did you overcome them?

    • changing the default styles of checkbox and slider
    • Creating the logic of password.

    What specific areas of your project would you like help with?

    • Better code structuring and improvements in code.
    P
    kayan 630

    @kayan2004

    Posted

    nice one! but there is a better way to write your strength function. check out this article. It has a formula to calculate the strength of a password

    Marked as helpful

    0
  • dolapobj 310

    @dolapobj

    Submitted

    What are you most proud of, and what would you do differently next time?

    Felt I was able to organize my javascript well. Hope it is easy to follow

    What challenges did you encounter, and how did you overcome them?

    Logic for displaying error messages and the validation

    P
    kayan 630

    @kayan2004

    Posted

    • The solution includes semantic HTML.
    • The layout does not work well on mobile.
    • The code is well structured but it is somewhat repetitive. And i noticed one issue in your website, It is that when you submit a form with errors, the error messages stay forever. You can add a function in your javascript file called hideMessage. -Overall, It is a very nice solution. Well done!
    0
  • @alexboliveira

    Submitted

    What are you most proud of, and what would you do differently next time?

    Gostei do procedimento do javascript, a acredito que, na próxima vez, irei tentar novos meios de manusear o dom com js

    What challenges did you encounter, and how did you overcome them?

    O processo de deixar um acordeão já aberto, surgiu algumas duvidas, mas foram solucionadas no desenvolvimento do projeto

    What specific areas of your project would you like help with?

    Na parte do js, teria alguma solução mais simplificada para obter o mesmo resultado

    P
    kayan 630

    @kayan2004

    Posted

    great design! good job.

    0
  • P
    kayan 630

    @kayan2004

    Posted

    Great use of semantic HTML. However, make sure to add your images folder in your project and try to match the right colors with the design. You can find the colors in the styles-guide.md file.

    0
  • Juan 480

    @JEWebDev

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am proud that i could finish the challenge applying what i have learned of html css and js without much complications so far.

    What challenges did you encounter, and how did you overcome them?

    how to round a number to only two decimal digits. The solution i found was to use the fixed method like this number.fixed(2)

    What specific areas of your project would you like help with?

    Any feedback is welcomed!

    P
    kayan 630

    @kayan2004

    Posted

    Nice one! Your code is also very well done, however I noticed that the bill can be put as a negative number. Try to fix that condition if you like!

    Marked as helpful

    0
  • P
    kayan 630

    @kayan2004

    Posted

    nice one! but dont forget to update the screenshot because it's showing your old design

    0
  • Felix 160

    @felix-stuff

    Submitted

    What are you most proud of, and what would you do differently next time?

    Most proud: Moving some repetitive JS in a function, getting regex to work. Stop trying to get the perfect solution, lost so much time along the way.

    What challenges did you encounter, and how did you overcome them?

    A ton of issues with JS: from syntax, to basic understanding why things aren't working and only solved by googling a lot.

    What specific areas of your project would you like help with?

    The JS can be improved for sure. I don't know how I could reduce the amount of code in a smart way or if it is already okay as it is?

    P
    kayan 630

    @kayan2004

    Posted

    nice one! you can barely tell the difference between the two

    Marked as helpful

    0
  • P
    Matt Cope 340

    @MatthewPCope

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm most proud of getting that button to work.

    What challenges did you encounter, and how did you overcome them?

    Getting the button to work was the hardest part for me. I researched more javascript and got help thru the community of frontend mentor.

    What specific areas of your project would you like help with?

    In general, if there are any ways to improve my solution I'd be more than happy to hear what others have to say.

    P
    kayan 630

    @kayan2004

    Posted

    great design but the profile should be hidden after you press the link

    0
  • @Shakil-a

    Submitted

    What are you most proud of, and what would you do differently next time?

    Most proud:

    • successfully created the grid layout on mobile and desktop
    • a more smoother transition for responsiveness from smaller screen size to larger ones than the last project

    what i would do differently:

    • I am still experimenting with the different approaches on whether to start on mobile or desktop first so maybe possibly try desktop first next time and see it is more effective with less css code

    What challenges did you encounter, and how did you overcome them?

    challenge 1 and solution: trying to condense the cards layout from the mobile desktop to a more condensed version on desktop:

    • I had used a media query and when the width was minimum 786px (larger than tablet) then the max width of the main container would drop to 70% and have no margin and the body would display flex and use justify center and align items to center the main container holding the cards, i would also drop the font sizes of the content

    What specific areas of your project would you like help with?

    • any bad practises in the code that i need to change
    • suggestions on better ways i could have approached this -any major design detail i may have missed to implement
    P
    kayan 630

    @kayan2004

    Posted

    -Nice html code overall, great use of semantic elements. -The code is somewhat accessible ( you used the alt property for images)

    • The layout looks good on most screens.
    • The HTML and CSS code is well structured and very much reusable. -There's not really much difference between the solution and the design
    1
  • P
    kayan 630

    @kayan2004

    Posted

    -Great use of semantic HTML elements, but you could've used the article element instead of div elements to represent the cards. -The layout is okay but not really similar to the original design. Try to play with the margins a little bit to get it right

    0
  • P
    kayan 630

    @kayan2004

    Posted

    try to set the height of the body element to 100vh and display it as flex and set align-items: center . That way there wont be white showing down there. The body will contain the whole page

    1