Skip to content
OverviewSolutions
28
Comments
9
katrine9176
@katrine9176

All comments

  • katrine9176•540
    @katrine9176Posted over 1 year ago

    Hello! Your solution looks really good! 🤗

    Here is some advice:

    • usually it's better to name HTML file as index.html,
    • use semantic tags, learn about that here -> article.

    Hope it was helpful and happy coding! 😁

    1
  • katrine9176•540
    @katrine9176Posted over 1 year ago

    Hello! Your solution looks very good! 😁

    Here is some advice:

    • put your CSS styles in style.css,
    • to connect style.css with HTML file add in <head> - <link rel="stylesheet" href="css/style.css">,
    • add CSS reset, learn about that more here -> article,
    * {
  margin: 0;
  padding: 0;
  box-sizing: border-box;
}
    • to make code better to read, consider downloading nice extension, if you use VSC I recommend prettier -> prettier, and for HTML default formatter,
    • update screenshot on frontendmentor :)

    Hope it was helpful and happy coding! 😃

    Marked as helpful
    0
  • katrine9176•540
    @katrine9176Posted over 1 year ago

    Hello! Your solution looks really good! 😁

    Here is some advice:

    • don't put your CSS styles in HTML file, instead of that create style.css file and there put them,
    • to connect style.css with HTML add in <head> - <link rel="stylesheet" href="css/style.css">,
    • I recommend you to use semantic tags, learn about that here -> article,
    • an article about IDs and CSS classes -> article,
    • in CSS reset you don't have to put %:
    * {
  margin: 0;
  padding: 0;
  box-sizing: border-box;
}

    Learn about that more here -> article.

    Hope it was helpful and happy coding! 😀

    Marked as helpful
    1
  • katrine9176•540
    @katrine9176Posted over 1 year ago

    Hi! Your solution looks really good! 😄

    Here is some advice:

    • in * put also:
    margin: 0;
padding: 0;
    • every page has to have one <h1> tag as a main headline,
    • I recommend you to use semantic tags, learn about it here -> article

    Hope it was helpful and happy coding! 😀

    Marked as helpful
    1
  • katrine9176•540
    @katrine9176Posted over 1 year ago

    Hello your solution looks really good! 😃

    Here is some advice:

    • don't put CSS styles in index.html, instead of that create style.css and there put your styles,
    • to connect style.css with HTML file, add in <head> - <link rel="stylesheet" href="style.css">,
    • add a CSS reset, learn about that here -> article, to do that add:
    * {
  margin: 0;
  padding: 0;
  box-sizing: border-box;
}
    • every page has to have one <h1> tag as a headline,
    • to center a card, try:
    body {
        display: flex;
	min-height: 100vh;
	align-items: center;
	justify-content: center;
}
    • I recommend you to use semantic tags, learn about it here -> semantic tags

    Hope it was helpful and happy coding! 😁

    Marked as helpful
    0
  • katrine9176•540
    @katrine9176Posted over 1 year ago

    Hello your solution is really good! 😃

    Here is some advice:

    • in * add only:
    margin: 0;
padding: 0;
box-sizing: border-box;

    the rest put in body,

    • add <h1> as a headline,
    • I recommend you to use semantic tags, learn about that here -> article

    Hope it was helpful and happy coding 😁

    Marked as helpful
    0
  • katrine9176•540
    @katrine9176Posted over 1 year ago

    Hello! Your solution looks really good! 😀

    Here is some advice:

    • add CSS reset to your CSS code, learn about it here -> CSS reset, to do that add:
    * {
  margin: 0;
  padding: 0;
  box-sizing: border-box;
}
    • here is an article about IDs and classes in CSS -> article.

    Hope it was helpful and happy coding! 😁

    0
  • katrine9176•540
    @katrine9176Posted over 1 year ago

    Hello! Your solution looks really good! 😁

    Here is some advice:

    • you shoud do a reset in css, read about that here -> CSS reset, to do that add in your CSS file:
    * { 
     margin: 0;
     padding: 0;
     box-sizing: border-box;
}
    • also I recomend you to use semantic tags, learn about it here -> sematic tags,
    • to center the card, add these styles:
    body {
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
}

    Hope it was helpful and happy coding 😃

    Marked as helpful
    1
  • katrine9176•540
    @katrine9176Posted over 1 year ago

    Hello! Your solution looks really good!

    Here is some advice:

    • don't put CSS styles in index.html file, instead of that make style.css file and there put your CSS styles from style tag,
    • to connect style.css with index.html add in <head> <link rel="stylesheet" href="style.css">

    Hope it was helpful and happy coding! 😃

    0