Skip to content
OverviewSolutions
9
Comments
1
Krimothiazine
@karim-saou

All comments

  • Krimothiazine•140
    @karim-saouPosted about 1 year ago

    Hi there!

    I liked your design especially the animation.

    But there is some issues:

    1. responsiveness: I 'm currently learning responsive design so I am not the right person to give you nice advice but I would recommend you two solid resources that may help you tackle responsiveness: odin project source, a very straight forward and short course. Kevin Powell course. a little bit long but very high quality.
    2. In details page (chosenCountry as you name it), the border countries do not show! the solution is simple: get the border countries from the api => you get border countries in abbreviation => transform it to full name => finally use full name as a path inside <Link> component of react router library.
    3. in details page we do not need input search and filter by region , you can get rid of them by moving the code of input and filter to your <Country/> component.

    react router has adopt a new approach of routing and you are using the old approach, I would recommend you this free and splendid react router course from Scrimba, you will learn both the old and the new approach and which and when would you use one of them.

    Good luck!

    1