Skip to content
OverviewSolutions
3
Comments
3
untoldbumpkins
@kaesle

All comments

  • untoldbumpkins•60
    @kaeslePosted over 1 year ago

    Very nice! The only discrepancy I can find is the position of the "76 of 100" text, which is more-or-less centered in the circle in the design, but rides a bit high in your solution. Might use a "position: relative" with some "top" to adjust it downward.

    Your solution to this is better than mine was. Good work.

    Matt

    Marked as helpful
    1
  • Azeezat•10
    @azeezatb-oSubmitted over 1 year ago

    Kindly look through my code and tell me if i implemented the flexbox right. I am completely new to the whole responsive web design and I would like to improve my web development skills, so I would really appreciate pointers from people that are more experienced. Thanks

    QR Code Component using CSS and Flexbox

    2
    untoldbumpkins•60
    @kaeslePosted over 1 year ago

    Azeezat,

    Your solution looks great! And it does respond to width changes. There is a bit of a problem with responsiveness to height, though.

    Your div.container has height 60%, while the contents don't scale the same way with height. A better solution might be to remove the "height" property, allowing the box to size to the content, and use padding to keep the negative space as the design requires.

    I'm not a professional myself, so keep your eyes out for comments from others.

    Matt

    0
  • untoldbumpkins•60
    @kaeslePosted over 1 year ago

    The design has centered text (text-align: center). Also, there are a couple of items in the accessibility report provided by frontendmentor that you might be finding out about right now 😀 (I found out in a comment on my solution.)

    Looks nice!

    0