Skip to content
OverviewSolutions
2
Comments
2
P
John Van Schultz
@jvansch1

All comments

  • John Van Schultz•40
    @jvansch1Posted 3 months ago

    Looks really good overall! If you have access to the figma file you should try to pay attention to some of those small details. For example, the picture of Greg is definitely a different size in your design than in the solution. Besides tiny things like that you did a great job!

    0
  • Solis-Dev•10
    @Solis-DevSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?
    • I´m proud of how fast I develop the challenge
    • In future challenges I will use a more responsive solution rather max-width
    What challenges did you encounter, and how did you overcome them?

    My principal challenge was the size of the card component that doesn't adjust to the content like in the design looks, my solution was the use of max-width, but I think that exists a better way.

    What specific areas of your project would you like help with?

    I would like to get help to learn about responsive layout

    QR code component using CSS flex-box

    1
    John Van Schultz•40
    @jvansch1Posted 3 months ago

    Looks good overall. I think one thing thing you could have done is separated the CSS into its own stylesheet and imported it in the head. Other than that your solution looks great!

    I am also new to CSS so I am not sure if max-width is the best way but I think what you did also makes sense

    Marked as helpful
    0