Skip to content
OverviewSolutions
3
Comments
3
Afan Khan
@justmrkhan

All comments

  • Major•50
    @PandaMajorSubmitted over 2 years ago

    I used bootstrap components (the card) to create the majority of the project, is it better practice to use something else?

    I am unsure of how to get the text to match up to the sample exactly and was wondering how people went about determining how to mimic the styles.

    QR Code using bootstrap 5 and custom CSS

    3
    Afan Khan•70
    @justmrkhanPosted over 2 years ago

    Hello,

    1. To understand your question, it is acceptable if you use bootstrap. It saves time on big projects. However, it is not important in small component challenges like these.
    2. Try not to keep links or alt texts empty. Also, you haven't added alt text at all. I suggest adding alt text for screen readers.
    3. For accessibility purposes, you must add the role tag in main divs and sections for screen readers.

    Other than that, I think the other feedbacks cover more topics.

    Marked as helpful
    0
  • Afan Khan•70
    @justmrkhanPosted over 2 years ago

    Hello Esteban,

    You can improve on the following points -

    1. I noticed you left alt tags empty. It is crucial to add content or a small description in the alt tag for screen readers to identify the property/element.
    2. According to the accessibility issues, you must add the role tag for screen readers. However, I suggest adding them to the main categories (not all of them).
    3. Avoid using random heading tags. Start with H1. You started with H2 at the beginning of your HTML file without the H1 tag.

    I believe the rest of it seems to be good. Good job, and good luck with your next challenge.

    Marked as helpful
    0
  • Afan Khan•70
    @justmrkhanPosted over 2 years ago

    Hello, I do not have any feedback as of now. However, I have a question.

    1. How did you add the border part to that avatar image? Do let me know since I missed that in my submission for the same challenge.
    0