P
justine1607
@justine1607
All comments
- Pjustine1607• 90
@justine1607
Posted
- for me i recommend not to use height on the text for dynamic, because when the content changes it's gonna be mess because for example the contend has exceeded from the height you add it will be not good.
- don't set px instead use relative units like em, rem.
- your margin-bottom to the hero-title could be remove and you just add gap to the hero-container so the hero-title and the hero text will have consistent gap.
0 - collins-ai• 130
@collins-ai
Submitted
Pjustine1607• 90@justine1607
Posted
nice its responsive.just wanna leave a comment your all div and other element should be inside the main like body-main-your div's.
Marked as helpful
0 - Kairo• 100
@Chikairo
Submitted
Pjustine1607• 90@justine1607
Posted
- border-top-style: outset; / / border-top-color: var(--cyan); / / border-width: 0.25rem; --this can be achieved by just one line of code try setting it to border-top: 5px solid var(--cyan);
- Use margin-left: auto instead. This will dynamically push the image to the right and is more flexible. Avoid using fixed values for margins unless absolutely necessary.
0 - RajanCP• 80
@RajanCP
Submitted
Pjustine1607• 90@justine1607
Posted
i like how you manage to use different images in different screen sizes.
0
