brukmg• 120
@brukmg
Submitted
joyafrikaana
@joyafrikaana
All comments
- joyafrikaana• 70
@joyafrikaana
Posted
hello brukmg, your code was quite clean and great.
Here are a few suggestions, I hope you might find helpful. For the sake of responsiveness, It's better to use rem than px for font-size as rem is scalable and adaptable while px is fixed unit that doesn't provide that flexibility. Also, using min-height: 100vh instead of height: 100vh ensures that the body grows if the content overflows.
Marked as helpful
0 - sofiasmnk• 80
@sofiasmnk
Submitted
What are you most proud of, and what would you do differently next time?
The challenge said to make the text responsive without using media queries. It wasn't hard to find guides online on how to do that with
clamp(), though figuring out thevwwidth value that seemed to work best was a bit trial and error. I'm glad the card width being responsive also worked without media queries.What challenges did you encounter, and how did you overcome them?
There were some inconsistencies in the Figma file. The "Design System" page claims
spacing-200is 16px, but the variable in Figma itself is actually set to 24px. It took me a while to realize why the padding on my version looked smaller than the one on Figma and on the preview file. In the end I decided to set it to 24px to follow how it looked rather than what it said.I also noticed that in the mobile version, the author's name is the only piece of text that doesn't get smaller. It felt weird to set a different
font-sizejust for the author name that wasn't the responsive custom property withclamp(). So instead, I let the author name be resized as well, and just set the author image size ineminstead ofremso that it would be sized down along with the text and not look weird.What specific areas of your project would you like help with?
On Safari, the SVG image has this weird bug (?). The "{" shapes on the bottom right corner are supposed to be half-black and half-white – when I open the page in Safari, they look all white. Weirdly enough, if I click and drag the image, it switches to showing half/half properly, but if I refresh the page it's all white again. I was afraid my CSS was affecting the image's styles somehow, but after checking, I saw all the SVG's colors are hard coded in hex code inline, so I don't think that's possible? I saw it seemed to be working fine on Firefox, so I chalked it up to Safari and gave up on trying to fix it, but it would be nice to know what's going on...
joyafrikaana• 70@joyafrikaana
Posted
Your code is well structured and readable. I love that it includes semantic HTML
0 - joyafrikaana• 70
@joyafrikaana
Posted
i love your code. It is quite responsive.
Marked as helpful
0
