Saleiux• 250
@Saleiux
Submitted
Jon Henrik Åvitsland
@jonhenrikaavitsland
All comments
- Jon Henrik Åvitsland• 190
@jonhenrikaavitsland
Posted
Also if you want some resources on flex and grid for layout these did me well:
https://css-tricks.com/snippets/css/a-guide-to-flexbox/ https://css-tricks.com/snippets/css/complete-guide-grid/#aa-introduction Also i think you should read up on box-sizing border-box: https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing
Good luck
Marked as helpful
0 - Saleiux• 250
@Saleiux
Submitted
Jon Henrik Åvitsland• 190@jonhenrikaavitsland
Posted
Hi Saleiux, thanks for the follow. I follow you back ofc :)
I know that you are learning to code, so am I, currently by school tho. But looking at your code, I want to mention some ideas that come to my mind and I hope it helps you improve on this design and furthermore when you work on new designs.
I suppose that you are a free user, if you pay for the membership you do get design files that you can utilize to improve beyond just the visual picture, but you don't have to.
I think that you forgot to declare the font family in your CSS file. You imported some font, but I can not see that it has been declared yet.
Also, I see that you are using padding to position your elements within the card, perhaps could flex have been used to some extent :)
You are using the rem unit size for width, I would rather use the rem unit size on font-sizes and a different unit on the width, and I think that in your case px is fine for width :)
Marked as helpful
0 - cocotiwak• 120
@cocotiwak
Submitted
Still dont know how to write JS script for update HTML with JSON file. Any clue Friends ?
Jon Henrik Åvitsland• 190@jonhenrikaavitsland
Posted
some resources for you :)
https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API https://developer.mozilla.org/en-US/docs/Web/API/Response/json
0 @PriyankaRC16
Submitted
Hi everyone!
I have a few issues with creating this card component.
-
The image of the card was not the same height as the text card even though I tried to inspect with the image height and the classes too.
-
Any other feedback is appreciated!
Thank you
Priyanka
Jon Henrik Åvitsland• 190@jonhenrikaavitsland
Posted
Hi Priyanka.
Just a suggestion, perhaps you should put the elements into one common container and let them adjust height by default.
Marked as helpful
0-
- waltuh12345• 390
@waltuh12345
Submitted
Anyone know where can I get a finished cloned challenges ?
Jon Henrik Åvitsland• 190@jonhenrikaavitsland
Posted
you get design files if you subscribe to paid plans here on this very page. :)
Marked as helpful
0
