Skip to content
OverviewSolutions
21
Comments
5
John Phillips
@john-k-phillips

All comments

  • Carlos•1,110
    @Carlos-A-PSubmitted about 3 years ago
    • I used the mathjs library and Javascript classes for this project.
    • I wanted to focus more on the accessibility and the Sass styling for this project so if anyone has tips or suggestions I'd appreciate it.
    • As an additional challenge, I wanted to implement a feature where the user can navigate the calculator keypad with the W, A, S, D keys too. I figured that the arrow keys are already reserved for the scrolling and didn't want to mess with that. If anyone has any helpful resources or articles, that would be very helpful as well.

    HTML, Sass, Javascript

    1
    John Phillips•350
    @john-k-phillipsPosted about 3 years ago

    Hey, just a note; your link to the GitHub repo returns an error 404.

    The design is pretty spot on! Nice work :)

    0
  • John Phillips•350
    @john-k-phillipsPosted about 3 years ago

    Good work on this card, a few things that I quickly noticed:

    • You have a fixed height on the card, you should avoid this; instead, make use of padding and margins to create the desired height. (This will prevent the text from wrapping outside of the container).

    • Don't forget to remove your console logs from JavaScript!

    • Within your HTML you have a list item that is commented out; perhaps remove that and push for an update.

    Marked as helpful
    1
  • John Phillips•350
    @john-k-phillipsPosted about 3 years ago

    I had a little peak at your JavaScript, perhaps move some of your code into their own functions?

    It might seem pointless at first, but it's much better for readability and debugging.

    Awesome project, defiantly better than my result! :)

    1
  • John Phillips•350
    @john-k-phillipsPosted about 3 years ago

    Awesome!! I love the white-spacing, I think you really nailed that.

    Here are a few things I noticed:

    • The height of your cards are too long, perhaps use a max-height?
    • The paragraph under your headings aren't spanning across to fit the design.
    • Your font colours are a touch off, check the style guide and add them in.

    Hope this helps, Happy coding.

    0
  • John Phillips•350
    @john-k-phillipsPosted about 3 years ago

    Just a few things I would look into tweaking...

    • Your header "WE'RE COMING SOON" needs to be aligned left.
    • Your input section also needs aligning left; perhaps lower the opacity on the placeholder.
    • Check the white spacing between your navigation logo and your paragraph line heights.

    Other than some white-space and alignment issues, beautifully done! <3

    Marked as helpful
    0