@ali-reza-2531Submitted 26 days ago
Jack Perez
@jmprzAll comments
- @jmprzPosted 26 days ago
Hello! Nice job for completing the challenge!
Upon seeing your work, I think there are need for improvement
-
You should include
<main>inside your<body>ensuring semantic HTML is present -
Fix proper margin/indention on your code at index.html, especially the
<a>tags
Overall, it looks good!
Marked as helpful1 -
- @mahenajTSubmitted 26 days agoWhat specific areas of your project would you like help with?
Feedback on improving the hover effects and tips for creating more efficient, maintainable CSS would be greatly appreciated!
@jmprzPosted 26 days agoHello! Good job for completing the challenge!
-
For hover effects, you can put these inside your CSS
.bottom h2:hover { color: var(--Yellow); } -
Looking at your CSS file, it looks great to me but you need to include semantic elements in your HTML like the
<main><article><section>etc.
Here some example HTML Semantic Elements
Marked as helpful0 -
- @aohinoyiSubmitted 27 days ago@jmprzPosted 27 days ago
Hello! Nice design even though it is different from the given design but good job on completing the challenge!
Maybe the shadow needs more improvement but overall it looks clean!
Marked as helpful0 - @DannimationsSubmitted 29 days ago@jmprzPosted 29 days ago
Hello! Looks good and congrats for completing the challenge!
Just want to give some insights
-
The link is not accessible to view
-
Change the color of the title "Improve your front-end skills by building projects" into
color: hsl(218, 44%, 22%);
Example:
<h3 style="color: hsl(218, 44%, 22%);><b>Improve your front-end<br> skills by building projects</b></h3>- Add space to the attribution section by using
margin-top
Example:
.attribution { font-size: 11px; text-align: center; margin-top:10px; }Overall, good job!
0 -
