Skip to content
OverviewSolutions
8
Comments
3
Jesse Ma
@jma26

All comments

  • Jesse Ma•95
    @jma26Submitted about 3 years ago

    I ended using CSS Grid for the layout of the mobile and desktop designs. Unfortunately I had a hard time lining up the social-media toggle box to line up with the share button (not sure it's because in CSS Grid?) and in order to line it up visually, I increased the padding but that resulted in a thicker-looking box. How did you guys approach this?

    I'd love to hear any feedback or suggestions on what I could improve on! Any insight is greatly appreciated!

    Thank you! #happycoding

    Article Preview w/ HTML, CSS, Vanilla JS

    2
    Jesse Ma•95
    @jma26Posted about 3 years ago

    Thanks for the feedback! I missed big time on the accessibility attributes...lol I guess that's what I get without checking.

    1
  • Eduardo Nascimento•140
    @eduardosgnSubmitted about 3 years ago

    Hello! If someone have tips and give a feedback to improve my code, it would be welcome! Thanks

    Responsive Page!

    2
    Jesse Ma•95
    @jma26Posted about 3 years ago

    Not a bad start! I'd recommend looking into updating the semantic elements of your upper-half part. You have a header tag wrapping the actual header and the star review section. I think it'd be wise to actually separate the star review section as its own section to be more semantically valid

    1
  • Jesse Ma•95
    @jma26Posted about 3 years ago

    I'd recommend looking into implementing box-shadows. Just from the "design comparison", it seems like there are no shadows at all especially on the "Proceed to Payment" button. A tad touch of a soft, diffused box-shadow would make the button + card show elevation.

    Marked as helpful
    0