any feedback?
Jhon Loyd Pastorin
@jlpastoAll comments
- @Maryan121Submitted about 1 year ago@jlpastoPosted about 1 year ago
Great use of semantic html. Well -organized and well-structured. Keep it up.
0 - @jhuanjulioSubmitted about 3 years ago
Had to submit the project regardless. Kinda stuck because I can't figure it out why its not aligned in the perfectly as it is on the screen of my laptop compared to when its published. So yeah, feel free to point out some pointers. I'll appreciate it a lot. Thanks!
@jlpastoPosted about 3 years agoHi, I learned that measurement matters, 1px off will make a difference especially in Fonts sizes. I try my best to replicate the design by measuring the JPEG files in Figma or Adbe XD
0 - @jhuanjulioSubmitted about 3 years ago
I ended up not adding up the main background(curve lines) because I don't know how to place it yet so if there's anything you guys can point out, It'd be much appreciated. Still working on the JS part. Will updated this file as soon as possible
@jlpastoPosted about 3 years agoHi , nice solution maybe just a little bit of resizing of element and measurement of margins and paddings. You can do that by putting the JPEG files to Adobe XD or Figma or PhotoShop to measure the boxes using a rectangle tool. I learned this technique in YT (Coder Coder).
I love the design for this challenge, I might do my own solution for this one. Anyways, great day ahead.
0 - @sebastienpuigrenierSubmitted about 3 years ago
Managing the curvy background was not easy and I am not fully happy with the result concerning the way it moves depending of the size of the screen...
@jlpastoPosted about 3 years agoHi, Nice solution. Almost there! I recommend putting the JPEG files to Adobe XD or Figma so we can measure the length of the design. Replicating the design perfectly is difficult so I personally use the above solution in measuring elements and getting the end-result close to design as possible.
Marked as helpful0 - @walidghtSubmitted about 3 years ago
Hello, I'm new to react and I'm not sure how am I supposed to style my components, is it better to use multiple CSS files for each component or just a big one for the entire page. also is there any best practices I should know? any tips? or things I could do better? and thanks in advance.
- @arnaudouttierSubmitted about 3 years ago@jlpastoPosted about 3 years ago
Hi. Great work. Maybe just need to tweak the font size of nav links for the desktop and the colors of h2 to match the design.
Marked as helpful0