Skip to content
OverviewSolutions
4
Comments
4
Justin Lowry
@jlowry42

All comments

  • Justin Lowry•60
    @jlowry42Posted 4 months ago

    Looks great! A few minor nitpicks:

    • you might use alt text for the img for more accessibility
    • perhaps also consider using some more semantic html elements, such as <main> and <aside>
    • accessibility will be improved if you specify font-size in relative unit such as rem instead of px

    Overall though this project looks very good. Well done!

    Marked as helpful
    0
  • Justin Lowry•60
    @jlowry42Posted 5 months ago

    Hi! I can't see your code, I guess the repo is deleted now or set to private.

    Solution looks good though! Looks like there might be slight differences from the design in terms of size, margins, padding, etc, but overall looks nice.

    One thing you might find helpful to get pixel perfect designs is to use an extension such as https://chromewebstore.google.com/detail/perfectpixel-by-welldonec/dkaagdgjmgdmbnecmcefdhjekcoceebi?hl=en

    Nice work!

    0
  • Justin Lowry•60
    @jlowry42Posted 5 months ago

    Looks great! A few small things:

    • there is no favicon for the page
    • I don't think the font will load correctly for users who do not have it installed on their system. You may need an @font-face declaration in your css to make it load properly
    • you may want to use a <main> tag in your document

    Besides these nitpicks it looks very good and matches the design perfectly. Well done

    0
  • Justin Lowry•60
    @jlowry42Posted 5 months ago

    pixel perfect! well done.

    the only suggestion i might have is to use some semantic html such as <main> for accessibility.

    also, perhaps consider using rem for font sizes instead of px?

    great job

    0