All comments

• 

  Martin• 40

  @MCoton

  Submitted almost 2 years ago

  

  QR Code Component challenge

  2

  70

  

  JJ Vega• 110

  @jjvega86

  Posted almost 2 years ago

  Great work on this, Martin!

  I have a few suggestions:

  • in your HTML, the card component and footer are both wrapped in div elements. This isn't bad for the component itself, but consider using a main semantic element to indicate which portion of the document contains the primary content. You may want to consider a footer element for the attribution as well. This is why you are getting the "

  • I noticed that the design for this component has the "Improve your front end skills" as a bold font-weight, but your final product doesn't have that weight assigned. That would be the last piece to making your code match with design.

  Marked as helpful

  0

  This comment has received 2 repliesShow
• 

  William• 190

  @tuaPuan83

  Submitted almost 2 years ago

  This is my first project after I have learned HTML/CSS from udemy. Please check my code and leave some advise. Thank you

  

  Product preview card by MaskCoder

  2

  20

  

  JJ Vega• 110

  @jjvega86

  Posted almost 2 years ago

  Great work on this, William. One suggestion - when moving into the mobile view, the image is quite tall and fills most of the viewport. I'd recommend setting a max-height/max-width on the image to make sure it scales well when shifting into the mobile view.

  Marked as helpful

  0

  This comment has received 1 replyShow