please check out my work and rate it.
Javier Lopez
@jglopezreAll comments
- @EmmanuelOludareSubmitted over 2 years ago@jglopezrePosted over 2 years ago
Hi, congrats, nice work, you could improve images sizing, using the object-fix CSS property for cutting images to cover entire box, maintaining sizes and ratio. You could use anchors for nav links, social links and other, and using :hover selector on these for make a pointing effect, like a color changing, scaling, or something else. You must use style guide where is how look in active mode. Greetings
0 - @StarisblackSubmitted over 2 years ago
i enjoy doing this a lot... open to suggestions and advice
@jglopezrePosted over 2 years agoHi, Congratulations... You could change color highlight text on text boxes, there are in style-guide.md. And, please, don´t forget making README.md page, with live link, we are able to test responsive and interactive behavior of the page.
Greetings.
Marked as helpful0 - @juliajgpSubmitted over 2 years ago
Hi! This is my first challenge here, and I'm a newbie. I'd love some feedback to improve and keep working.
@jglopezrePosted over 2 years agoCongrats.. I suggest to you, at footer, in social links, you have to wrap every <img> into an anchor <a>, for give to icons the possibility to send user to respective page, and you could give to <a> margin-left and margin.right to open space between. Optionally, you could give to these new <a> option to hoverize (a:hover) giving interactive response when user pass mouse pointer over a icon.
Greetings.
Marked as helpful1 - @jglopezreSubmitted over 2 years ago
Hi guys, i need some ideas, about image on background, I don't know how to make it to cover entirely background when resolution is greater than 1440px, I used object-fit: cover but it doesn't perform changes. Thank a lot for yours answers. Greeting.
@jglopezrePosted over 2 years agoNice, I am going to test it, I like use media query for background changing, but, i hadn't thought in it. Thank.
0