Skip to content
OverviewSolutions
15
Comments
28
Jordane Gengo
@jgengo-alt

All comments

  • Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello Graeme Byrne, I'm glad to see you did this assignment!

    🪴 Your solution looks great however I think:

    🌱 • (UX) • It would have been great if the text input also permit to validate the form with the ENTER key. You could have achieve that by using a real form html element instead of a div or by adding event listener with JS.

    🌱 • (UX) • The dashboard image attract all of the focus, it could look a bit better if have lower this effect by increasing the size of your headers in desktop mode to balance it out.

    🌱 • (UI) • The error message in desktop mode isn't place properly.

    Your mobile version is perfect 👌 

    I hope it helps Cheers happy coding 💪

    0
  • Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello there 👋

    First of all, good job for completing the assignment 🚀

    It seems the validation of the form isn't working, and can't find any trace of javascript, I would suggest you try to do it you could learn a lot! 🌱

    Also, looks like you didn't do the mobile version of the page.

    Keep going 💪

    0
  • Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello Luciana 👋

    You really nailed it! 🚀

    I don't have any negative feedback, just wanted to pass-by to let you know I like your solution, works pretty nite and your JS code is super clean!

    Keep doing a great job 💪

    Marked as helpful
    0
  • 👾 Ekaterine Mitagvaria 👾•7,600
    @catherineisonlineSubmitted over 2 years ago

    Hello, Frontend Mentor community! This is my solution to the Pricing component with toggle.

    I appreciate all the feedback you left that helped me to improve this project. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.

    You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.

    Thank you

    Pricing component with toggle

    6
    Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello Catherine 👋 good job completing this challenge. Keep up the good work 💪

    🪴 Your solution looks great however I think:

    🌱 • In terms of UX it would be better if your toggle button is clickable from the whole div and not only the circle

    🌱 • Also, your side buttons seems to change the border-radius on hover which makes it a bit weird to the user eye.

    🌱 • On wide screen it looks extremely huge, you would benefits having a container with a max-width

    Hope this help and happy coding!

    Marked as helpful
    1
  • Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello Gustavo 👋

    Unfortunately your solution is not responsive, are you planing on re-taking it and trying to implement it? That would be great!

    Keep going my friend! 💪

    0
  • Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello 👋

    First of all, great job Antonio 🚀

    My only feedback regarding your assignment is that your share button has a position absolute relative to the body, not the card so on a wide screen your share button isn't inside the card.

    Keep going 💪

    Don't hesitate to follow me and give me feedback to my assignments :) I will follow back and make sure to give you advices in the future if you are interested!

    Marked as helpful
    0
  • Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello there 👋 I'm back to give some advice on your latest assignment :)

    I find interesting that you made yourself the -- " -- under the advices instead of using an image, you gain speed in loading the page, that's awesome!

    However, what you gain to load the page, you sadly lost it by reloading the page everytime we click the button. Would have been better to make onclick call a function that would have fetch a new advice and replace only the needed text on the page instead of reloading everything.

    Also with a wide screen, your main div would have benefits having a max-width ;)

    Keep going 💪

    Marked as helpful
    0
  • Graeme Byrne•520
    @grmbyrnSubmitted over 2 years ago
    What are you most proud of, and what would you do differently next time?

    I made this a long time ago so don't remember.

    What challenges did you encounter, and how did you overcome them?

    I made this a long time ago so don't remember.

    What specific areas of your project would you like help with?

    I made this a long time ago so don't remember.

    Responsive four card feature using CSS Grid

    2
    Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello there my dear friend 👋

    First of all, great job 🚀

    On a wide-screen your layout is a bit too spacy, would have been great to add a max-width of 1200px to your parent div

    Also it would have been more intuitive to add position: relative to the card, and position: absolute; to the image so you can place it in space with more "relatable" position like bottom: 2em; right: 2em;

    Once again you did tho a great job!

    Keep going 💪

    Don't hesitate to follow me and give me some feedbacks on my assignments, I will follow back and try my best to give you feedbacks to your future posts :) 🪴

    Marked as helpful
    0
  • Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello there 👋

    First of all, great job 🚀 I really like your addition of the small border on the share button, it gives the vibe of being button compared to the very flat one the preview design. Also, your grid is nite!

    However, I noticed a small issue with your solution: your social media buttons are clickable even if not displayed, you should use a display: none; and toggle it instead of an opacity: 0;

    More a UX than UI feedback, but

    • in mobile version, the translation of the share from the bottom to the top would be better than the left to the right 🪴
    • in desktop version, I feel like the button share could toggle instead of having the hover effect: when tooltip display button dark, when not light. 🌱

    Once again, great job!

    Keep going 💪

    Don't hesitate to follow me on and give me feedback on my assignments! I will follow back and keep giving you feedback if you are interested for your future publications.

    Marked as helpful
    1
  • Mahnoor Khan•455
    @mahnoork18Submitted over 2 years ago

    i cant figure out how to change advice# along with the advice text can anyone help me out? Do give your feedback #firstapiproject

    Advice app generator

    1
    Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello there 👋

    Your assignment looks great 🐱🔥

    So to reply your question on how to actually change the id here are some hints that could help you:

    You already have an id for your text advice #X, I would suggest a different name though like advice_id instead of id

    <p id="advice_id">Advice #1</p>

    So you can

    const adviceId = document.querySelector("#advice_id");
const advice = adviceData.slip;
adviceId.innerHTML = `Advicce #${advice.id}`

    You can take a look at my assignment javascript, it could help you to understand here

    Keep going 💪

    Don't hesitate to follow me, I will follow back and give you advice for your future assignments if you are interested 🌱

    Marked as helpful
    0
  • Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello there 👋

    First of all, good job 🚀

    I noticed few improvement possible 📋

    • In your style.css, at the very bottom of the file you have empty rulesets, you should try as much as possible to avoid it.

    • You didn't add any box-shadow to your card, I assume you forget, however box-shadow can be a bit tricky sometime, so don't hesitate to practice it when you have the occasion 🌱

    • Also, to be a bit picky, your card isn't vertically centered. It's not very important, but when for example opened with an iPad it can look a bit odd...

    Once again, you did great! 🚀 Keep going 💪

    Don't hesitate to follow me, I will follow back and make sure to give you feedbacks for your future post if you are interested 🦉

    Marked as helpful
    0
  • Jordane Gengo•590
    @jgengo-altPosted over 2 years ago

    Hello 👋

    You did a great job 🚀

    My only feedback would be to have two different height for the share tooltip from mobile and desktop. Because in desktop very the share tooltip just look super huge compare to your component. 🐱

    Keep going 💪

    Marked as helpful
    1