Skip to content
OverviewSolutions
6
Comments
4
Jeury Santos
@jeurysantos1

All comments

  • Yafi Abyan•40
    @abyanfalahSubmitted over 1 year ago

    I'm using Vue cdn for this solution, i wonder if i did it the right way. I put the Vue createApp in a separate file named app.js in the same directory as index.html and call it via tag from the html.

    Also, you might notice improper usage of html tags. Although my main focus is slicing the design, accessibility is important and i will learn it in the future. Please give me feedback regarding this particular thing, because currently i don't know what i don't know on this kind of stuff.

    And lastly, please check the responsiveness of this solution. I need to know if i did it right.

    Any feedback is welcome!

    Thank you!

    Responsive result summary using HTML Vue and TailwindCSS

    1
    Jeury Santos•115
    @jeurysantos1Posted over 1 year ago

    This is what I called a responsive website !! I loved how the UI adapt to different breakpoint I went to read your code and it such easy to read and maintain

    1
  • Tati Muniz•65
    @tatimunizzSubmitted almost 4 years ago

    This was my second time doing this challenge. I have redone it using React and Styled Components.

    I am pretty happy with the profile card, but please, feel free to give me any tips to improve my code.

    Also, the background SVG placements were hard for me and I have no idea how to make it work seamless for mobile and web.

    Profile Card Component made with React and Styled Components

    2
    Jeury Santos•115
    @jeurysantos1Posted almost 4 years ago

    Hey Tati.

    I loved Sass as well, and I am glad you used it. I like the organization of your environment (everything on its own on file).

    Easy to read= easy to maintaining; Those are hard to accomplish, and you killed it.

    Something that I didn't see the design wasn't responsive to a cellphone viewport of the 375px. In the future trying to use more Media queries, so you modify your design to the viewport required.

    And How you get to have so much perfect preview ??

    1
  • Jeury Santos•115
    @jeurysantos1Posted almost 4 years ago

    Something very important in every developer is to write a code that is readable by others so a maintainability is an option and You killed that.

    I would like to see the design more responsive to different breakpoints. I notice at the 1440px bp the IMG-patterns were located in the right place due that was set Top:0 RIGH:0. and in my personal opinion I would use more (REM) INSTEAD (PX) to give you more freedom when it comes to code high values.

    and gain how your preview is so perfect ???

    2
  • Jeury Santos•115
    @jeurysantos1Posted almost 4 years ago

    I really like how easy was to understand your code. One thing that I would do differently is not to insert the Pattern Images into your CSS, instead of into your HTML so you could position them in the right place in every single break Points.

    As well, you should have used the benefits of Media query in your CSS that would make the layout or design more responsive and won't avoid the design to break.

    0