@simplyObareSubmitted 3 months ago
Jennifer Rothrock
@jeniveredeAll comments
- @MosacdSubmitted 3 months agoWhat challenges did you encounter, and how did you overcome them?
I should probably spend less time trying to make it a perfect match to the original and focus on practical stuff.
What specific areas of your project would you like help with?When it comes to using different units for text elements, when to use rem, em and percentages.
- @KapkrazySubmitted 4 months ago@jeniveredePosted 4 months ago
Looks great! I have no suggestions for improvement.
0 - @Y-ashbhattSubmitted 5 months ago@jeniveredePosted 5 months ago
In the original design PERFUME looks like it uses regular(400) font weight but in this solution it looks medium(500)? Otherwise, looks great!
1 - @noormuhammadrazaSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I just guessed the spacing, font-size, font-weight and colors. The image was very big because it was supposed to be a scrollable page therefore getting everything accurate and exact was quite difficult and having a figma design for such challenges would be very helpful in the future. Nevertheless I tried my best to use correct judgements about all the above mentioned things.
What challenges did you encounter, and how did you overcome them?Spacing (Margin and Padding) Font size Font weight Colors
What specific areas of your project would you like help with?I want to know if there is anything major which I am getting wrong and which could lead to a weak base if I continue that. Any such practice that I should change or any tip on how to style more efficiently. How to write less css
@jeniveredePosted 5 months agoMy only suggestion is to make the css for the mobile view, then add a media query at the end for the desktop view. This is the desktop view, it looks good to me. :)
Marked as helpful0 - @Yuvraj-H3R3Submitted 5 months agoWhat are you most proud of, and what would you do differently next time?
Doing Javascript in that
What challenges did you encounter, and how did you overcome them?Minor problem with CSS positioning
What specific areas of your project would you like help with?None
@jeniveredePosted 5 months agoLooks good, I have no suggestions for improvement.
1 - @AlexSG29Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I am proud to be able to do it all on my own. I would like to have done it with a more stylized and organized code and for that for next time I want to use some framework
What challenges did you encounter, and how did you overcome them?The main challenge for me was that some containers were aligned to the left and others in the center, but all on the same card. To do this, I had to investigate the flex-self property that serves precisely for this.
What specific areas of your project would you like help with?I feel like my CSS code is too long and I use too many callouts. I would like to know how I could make it shorter and more stylized.
@jeniveredePosted 5 months agoOnly suggestion I can make is to add line height: 1.6 to the grey paragraph text (p id=description in your code). That will give space between the lines of the text, so it is easier to read.
Otherwise, it looks really good!
Marked as helpful0 - @SlavaKolesnikSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
So far there is nothing to be proud of. Next time I want to make styles using type libraries Tailwind CSS or Bootstrap.
@jeniveredePosted 5 months agoI would move the attribution below the card, since it is not included in the design image. Otherwise, looks great!
1
