@Lescano713
Submitted
@jefiedler
@Lescano713
Submitted
@jefiedler
Posted
The solution is good. The design was kept as intended. It is normal that a design cannot usually be reproduced 1 to 1 on the web. Which is why there is a discrepancy. This is not a big deal.
Feedback on the CSS:
The only thing I notice is that your CSS is very difficult to read. This applies especially to the section from body, .box-container {
} . Personally, I would separate the classes more. It's nice that you use CSS features here, but unfortunately this makes it a bit unreadable. In addition, you can only use this CSS for this project and only for this area. If you split up the CSS more, e.g. into the classes .card
, .card-content
, .card-media
, you can also use them elsewhere. In addition, this increases readability.
Feedback on the HTML:
The HTML is generally good. It might make sense to use main
for the div
with the class box-container
and the tag footer
for the div
with the class attribution
instead of the div
s. This is semantically more correct HTML. If this were a React component, I would also use div
s.
Otherwise, all other tags fit, I would possibly replace the h3
tag with an h1
tag and possibly adjust the font size. But this is not absolutely necessary.
Otherwise, a really great job. Keep up the good work.
Marked as helpful