Aaliyan10• 190
@Aaliyan10
Submitted
jcoms2003
@jcoms2003
All comments
- jcoms2003• 100
@jcoms2003
Posted
@Aaliyan10
Great job finishing your first project! Just a few suggestions. First, if you are trying to use flexbox to center the QR code container make the body the main flex container. You would do this by...
body { display: flex; justify-content: center; align-items: center; height: 100vh; width: 100%; }Also, try to use semantic elements like
<main></main> <section></section>so on and so forth...Overall, great job finishing your project and good luck with your next!
Happy coding! ;)
0 What are you most proud of, and what would you do differently next time?
I think I made a very similar copy of this challenge version.
What challenges did you encounter, and how did you overcome them?
I think I usually overthink which semantic elements use.
What specific areas of your project would you like help with?
Did I make good html elements choices ? I gladly receive a feedback about that. Thank you!
jcoms2003• 100@jcoms2003
Posted
@peter-hasznos
Your solution looks great! One thing I would say is try to work with the pseudo classes like :hover to make your UX more engaging. You could make a box shadow on hover to create a button effect or make the font color change. Overall though, your design is very close to the original. Keep up the good work!
Happy coding ;)
Marked as helpful
0- Lucasdev• 30
@Lucasss-dev
Submitted
jcoms2003• 100@jcoms2003
Posted
@Albertnoteinstein
Great job finishing the assignment. Just a few suggestions...
-
Make your container paddings a little smaller to get a little closer to the original. (I know this one is hard but try your best to imitate it!;))
-
Focus more on just getting the basics right and not dive right into the transitions and stuff. Try making it easier on yourself and make it as basic as possible!
-
Finally, on your index.html you are missing you <section> closing tag. Just try to focus on small things!
Overall, great work getting on here and getting a challenge done, I'm pretty new myself and have found the above advise to really help!
Happy Coding!!
Marked as helpful
0 -
- Muhammed Ali• 160
@Mohamed-ben-Ali
Submitted
jcoms2003• 100@jcoms2003
Posted
@Mohamed-ben-Ali Code looks good. Just one small thing, maybe add the pseudo-class :hover for your main container so you get the button effect. Also, you can use Flexbox to align your content...here's a helpful website to study Flexbox
Marked as helpful
0 - Fuad Hasan Emon• 10
@fesrio
Submitted
jcoms2003• 100@jcoms2003
Posted
Code looks good! Almost perfect mirror to template!
0
