jcoms2003
@jcoms2003All comments
- @Aaliyan10Submitted 5 months ago@jcoms2003Posted 5 months ago
@Aaliyan10
Great job finishing your first project! Just a few suggestions. First, if you are trying to use flexbox to center the QR code container make the body the main flex container. You would do this by...
body { display: flex; justify-content: center; align-items: center; height: 100vh; width: 100%; }
Also, try to use semantic elements like
<main></main> <section></section>
so on and so forth...Overall, great job finishing your project and good luck with your next!
Happy coding! ;)
0 - @peter-hasznosSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I think I made a very similar copy of this challenge version.
What challenges did you encounter, and how did you overcome them?I think I usually overthink which semantic elements use.
What specific areas of your project would you like help with?Did I make good html elements choices ? I gladly receive a feedback about that. Thank you!
@jcoms2003Posted 5 months ago@peter-hasznos
Your solution looks great! One thing I would say is try to work with the pseudo classes like :hover to make your UX more engaging. You could make a box shadow on hover to create a button effect or make the font color change. Overall though, your design is very close to the original. Keep up the good work!
Happy coding ;)
Marked as helpful0 - @Lucasss-devSubmitted 5 months ago@jcoms2003Posted 5 months ago
@Albertnoteinstein
Great job finishing the assignment. Just a few suggestions...
-
Make your container paddings a little smaller to get a little closer to the original. (I know this one is hard but try your best to imitate it!;))
-
Focus more on just getting the basics right and not dive right into the transitions and stuff. Try making it easier on yourself and make it as basic as possible!
-
Finally, on your index.html you are missing you <section> closing tag. Just try to focus on small things!
Overall, great work getting on here and getting a challenge done, I'm pretty new myself and have found the above advise to really help!
Happy Coding!!
Marked as helpful0 -
- @Ojay16Submitted 5 months ago@jcoms2003Posted 5 months ago
@Ojay16 Good Work, code is clean and easy to read. Good luck with your front-end development journey.
0 - @Mohamed-ben-AliSubmitted 5 months ago
- @fesrioSubmitted 5 months ago