Jose Chaparro
@jchaparAll comments
- @jefflangtechSubmitted almost 2 years ago@jchaparPosted over 1 year ago
Amazing Job on this Jeff! Your site looks good on mobile, tablet and desktop view points! I have to say its not to often the project/challenge slider looks almost identical. Appreciate the feedback given on my challenge. Happy Coding!
0 - @iagohenrique2009Submitted over 2 years ago
Any feeback of how i improve my code?
@jchaparPosted over 2 years agoHey Iago! Nice work on this challenge. Once thing I noticed in you styles is that you put JUSTIFY-CONTENT twice in the Main elements styles. First time as Center and the second as Flex-Start. If you're looking to center the content it would be best to do Justify-Content and Align-Items as center. I'm guessing you went with a Desktop first approach and this should help center you content on desktops.
Marked as helpful1 - @jchaparSubmitted over 3 years ago
Hello Everyone, any feedback would be greatly appreciated! Would love to get some advise on how I could have matched the design better. Darker overlay, content width etc.
@jchaparPosted over 3 years agoI redid the HTML markup and went with a mobile approach when it came to styling it. I feel happy that this version looks a lot better than the first submission. The one thing I've been having an issue with is the dark violet line underneath the image. I'm still currently looking but haven't been able to figure out why this line is visible on mobile and not desktop.
0