Richard Marks• 240
@Richard2957
Submitted
The logic of calculators, especially when it comes to chaining functions, is quite fun. Division by zero gives and Infinity error - I left it like this to say infinity because I thought it looked good.
Jennifer Boateng
@jboat86
All comments
- Jennifer Boateng• 90
@jboat86
Posted
Hello Richard
Great app! I love how you've applied multiple themes and I love the dark purple one, in particular. However, to make code more readable and well structured it's best to put your js code into a separate file eg: app.js (external js). Lastly, consider applying semantic HTML in your mark-up for example for your button you could add a <button> tag as opposed to a <div>. Hope this helps.
0 - Hannah O• 60
@hannahro15
Submitted
Hello, any feedback would be much appreciated. I had a few problems lining up the icons next to the small text, above the footer/image at the bottom. I also didn't know how to do the straight line across above the footer, and the active states. Other than I think it is ok. Thanks.
Jennifer Boateng• 90@jboat86
Posted
Hello Hannah. Overall, good attempt. However, I'll note the following issues:
Solution on mobile view is missing the following features:
the horizontal line is not showing SVG icons beside the text in the flex layout is slightly are not aligned.
On Desktop view: Overall alignment needs to be adjusted, including the avatar image I would thus, suggest the following changes:
Best to put the "@import" link at the very top of the external CSS file rather than in the HTML style tag; makes code more neat and readable by others.
Rename "element-1&2" to something more meaningful e.g: equilibrium-image- I know it"s a bit longer but it's best to use names provided in the styling guide. This is to make the code again more readable.
The avatar image is missing the white border and the active state doesn't work.
Rename element-1&2 to something more meaningful like equilibrium-image for example (I understand it's a lot longer than your example, but makes code easier for someone else to understand-best to use names provided in the style guide). I know I've written so much here, but I hope this helps. Best of luck.
Marked as helpful
0 - Lucas Bispo• 50
@LucasBispoMenezes
Submitted
willing to listen to feedback
Jennifer Boateng• 90@jboat86
Posted
The HTML seems OK overall, but I would style the attribution in the main CSS file and its also in the head of the document (it should be in the body as it makes the code more readable and organised). With the CSS, there are few things missing; the given colour variables has not been applied to p selector and heading. Hope this helps. Well done, best of luck and keep coding!
Marked as helpful
1
