@Benji003Submitted over 2 years ago
javascriptooo
@javascriptoooAll comments
- @javascriptoooPosted over 2 years ago
Given the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. Here is some documentationAdding the
<main>landmark will remove 2 accessibility issues! :)Headings are used by screen readers for people to navigate the page. An
H1is the main topic. So users can jump to it. If you have multiple headings, the user can skip them in screen readers.That should take care of the final accessibility issue.
Check out this Headings Documentation
Hope that helps! Great work!
Steven
Marked as helpful1 - @ejikemechiozoadiroSubmitted over 2 years ago
This is my first challenge on Frontend Mentor I'd really appreciate feedback on the challenge
@javascriptoooPosted over 2 years agoGiven the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. (Looks like you forgot to place the opening<body>tag as well.) Here is some documentationAdding the
<main>landmark will remove 2 accessibility issues! :)Marked as helpful0 - @KarthigeyankirubaSubmitted over 2 years ago
I faced difficulty to responsive the page
@javascriptoooPosted over 2 years agoGiven the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. Here is some documentationAdding the
<main>landmark will remove 2 accessibility issues! :)Also, with accessibility, you cannot skip headings. Change your
h3tag to anh1and stylize the text from there. Headings are used by screen readers for people to navigate the page. AnH1is the main topic. So users can jump to it. If you have multiple headings, the user can skip them in screen readers.That should take care of the final accessibility issue.
Check out this Headings Documentation
Hope that helps! Great work!
Steven
0 - @eizan97Submitted over 2 years ago@javascriptoooPosted over 2 years ago
Given the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. (Looks like you forgot to place the opening<body>tag as well.) Here is some documentationAdding the
<main>landmark will remove 3 accessibility issues! :)Also, with accessibility, you cannot skip headings. Change your
h3tag to anh1and stylize the text from there. Headings are used by screen readers for people to navigate the page. AnH1is the main topic. So users can jump to it. If you have multiple headings, the user can skip them in screen readers.Check out this Headings Documentation
Hope that helps! Great work!
Steven
Marked as helpful1 - @OPantheraSubmitted over 2 years ago@javascriptoooPosted over 2 years ago
Given the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. Here is some documentationAdding the
<main>landmark will remove 3 accessibility issues! :)Also, with accessibility, you cannot skip headings. Headings are used by screen readers for people to navigate the page. So users can jump to it. If you have multiple headings, the user can skip them in screen readers.
Check out this Headings Documentation
Also, any time you add an
<img>tag, you must include an `alt="your description here" attribute. It also helps with accessibility.Inside the
<head>tag, you will need to insert a<title>. :)Hope that helps! Keep hustling!
Steven
0 - @ghada-emadSubmitted over 2 years ago@javascriptoooPosted over 2 years ago
Hi there!
Given the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. Here is some documentationAdding the
<main>landmark will remove all accessibility issues! :)Hope that helps! Great Work!
Steven
0 - @yashk87Submitted over 2 years ago@javascriptoooPosted over 2 years ago
Given the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. Here is some documentationAdding the
<main>landmark will remove 2 accessibility issues! :)Also, with accessibility, you cannot skip headings. Change your
h3tag to anh1and stylize the text from there. That will resolve the final accessibility issue!Headings are used by screen readers for people to navigate the page. An
h1is the main topic. So users can jump to it. If you have multiple headings, the user can skip them in screen readers.Check out this Headings Documentation
Hope that helps! Great work!
Steven
0 - @vega-bitSubmitted over 2 years ago
please review my code
@javascriptoooPosted over 2 years agoGiven the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. Here is some documentationAdding the
<main>landmark will remove 2 accessibility issues! :)Also, with accessibility, you need headings. Add an
<h1>tag instead of the<p>tag.<p class="testimonial">to<h1 class="testimonial">and stylize the text from there. That will remove the final accessibility issue. Headings are used by screen readers for people to navigate the page. An
<h1>is the main topic. So users can jump to it. If you have multiple headings, the user can skip them in screen readers.Check out this Headings Documentation
Hope that helps! Great work!
Steven
Marked as helpful0 - @yudiwdyntoSubmitted over 2 years ago
I would appreciate any feedback
@javascriptoooPosted over 2 years agoHi there!
Very, very nice. I really love your inclusion of css variables to make it easier to update later!
As far as feedback, a minor edit but your
product-categorytext should be PERFUME instead of PARFUME.Hope that helps! Great work!
Steven
Marked as helpful0 - @carlosCosta24Submitted over 2 years ago@javascriptoooPosted over 2 years ago
Given the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. Here is some documentationAdding the
<main>landmark will remove 2 accessibility issues! :)Also, with accessibility, you cannot skip headings. Change your
h2tag to anh1and stylize the text from there. That will resolve the final accessibility issue!Headings are used by screen readers for people to navigate the page. An
h1is the main topic. So users can jump to it. If you have multiple headings, the user can skip them in screen readers.Check out this Headings Documentation
Hope that helps! Great work!
Steven
Marked as helpful1 - @LuisJimenez19Submitted over 2 years ago@javascriptoooPosted over 2 years ago
Hi there! with accessibility, you cannot skip headings. Change your
h4tag to anh2and stylize the text from there. Headings are used by screen readers for people to navigate the page. Anh1is the main topic. So users can jump to it. If you have multiple headings, the user can skip them in screen readers.Check out this Headings Documentation
Hope that helps! Great work!
Steven
Marked as helpful0 - @oviematthewSubmitted over 2 years ago
I am still unsure about the best practices to centre a div vertically, but I believe padding came through, this ismy first week learning CSS, and I am buzzed up to design more
@javascriptoooPosted over 2 years agoGiven the accessibility issues -- you need to include at least the
<main>landmark.The
<main>landmark tag can be inserted around your content inside the<body>. Here is some documentationAdding the
<main>landmark will remove all 3 accessibility issues! :)Hope that helps! Great work!
Steven
Marked as helpful0
