I really enjoyed this tutorial by Kevin Powell. Working on the design system page first was an interesting way to get started, now I kinda wish all the projects had one! The only problem I had was that the tutorial proceeded by designing the layout for a certain size screen, but then I had to deal with sizing and spacing the elements when the window is full size.
José Geraldo de Souza Jr
@jGsouzaJrAll comments
- @scottmotionSubmitted over 1 year ago
- @ahmedlasheen2472009Submitted over 1 year ago@jGsouzaJrPosted over 1 year ago
Hey, all right!?, I wanted to leave a tip for you to centralize your work, which is display: flex; margin: auto;
by doing this your container will be centralized, in the summary part use <h4> use <p> the <span> are right, when starting a styling always use these start properties
*{ margin: 0; padding: 0; text-decoration: none; list-style: none; box-sizing: border-box }
so, the margin, the padding, you put it, because each browser has a standard and your work can be like in Edge, but bad in Safire
for mobile use @media (max-width: 'look in style guide size';)
0 - @KiruthikaKanaguSubmitted over 1 year ago
All comments are welcome
@jGsouzaJrPosted over 1 year agoHello, looking at your code, I noticed that there are no small errors, the 'card' DIV has the same color as the 'container' DIV, thus not giving contrast and making it look like it's something loose on the page, the biggest mistake is having commented the code that came in the exercise, the alignment is good, but there are some details that, looking at the example more calmly, you will notice, but nothing that disturbs.
espero ter ajudado, não vou indicar seus erros pois o desafio é um trabalho de observação e tenhar fazer igual, ou mudar algo e chegar mais perto do resultado! No meu mesmo mudei a cor queria algo diferente olho o W3school, ou qualquer site da sua preferência.
0 - @lalvarezzSubmitted over 1 year ago@jGsouzaJrPosted over 1 year ago
Your work is very good, but you still need to have a notion of alignment!
You can imagine a line under the word Great crossing over to the other horizontally and having to put the element in the same alignment!
I don't know what your browser is but if it's Chrome use the VisBug extension
Hope this helps!
0 - @prjwl16Submitted over 1 year ago
As a new to Frontend, faced a lot of issues. But this is my first draft. i will definitely improve it.
@jGsouzaJrPosted over 1 year agoHello my brother, look, you need to think more about what to do, because you didn't pay attention to the details, a simple example display: flex; and margin: auto;
centralize your work.
When you don't know you can go into other Devs' code and see how they solved something and it can help you get where you want to be.
my code: https://github.com/jGsouzaJr/result_summary
Marked as helpful0