ivan-josef
@ivan-josefAll comments
- @Hossein-H-ISubmitted about 1 month ago
- @EdoardoRamondettiSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
i am proud i have completed this project
What challenges did you encounter, and how did you overcome them?i have some problems with the media query
What specific areas of your project would you like help with?everything
@ivan-josefPosted 3 months agohi bro, congratulations for doing this
but it seems like some settings are missing, mainly for the fonts, you haven't configured the "perfume" and the paragraph size is too big, the weights need to be revised too.
0 - @Dhia-18Submitted 4 months ago
- @RabelahmedSubmitted 4 months agoWhat specific areas of your project would you like help with?
i get confused about the size of the whole card element and i dont know if i'm using fonts right or not if you think i could do something that can improve my solution let me know, thank you
- @Szafter12Submitted 4 months ago@ivan-josefPosted 4 months ago
in my opinion you made a great solution, but I think it's a good code practice to make a different file for your style and I like to keep things more organized like putting the variables (* and :root) on top of each other and do the same for the rest of the code, writing the css in the order you did the html. and a friend told me in my last challenge that it is better to use a div outside the tag you are going to use flexbox than to use the body tag
1 - @catreedleSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of positioning the elements correctly and figuring out flexbox, margin, and align-items. I think I need to create an HTML markup and CSS template for positioning elements with an understandable note so I can solve similar problems more quickly next time.
What challenges did you encounter, and how did you overcome them?I struggled mostly with centering the elements. I searched the internet for how to do it and had to go through trials and errors.
What specific areas of your project would you like help with?How can I improve my code, especially on the elements where I use fixed size (the card and the image)? Do you know a better way to do it? Also, my explanations on how to center elements, are they clear enough or need some corrections?
@ivan-josefPosted 4 months agoI think it turned out really good, I'm sorry I don't have the knowledge to help you now
0