All comments

• 

  soma•60

  @soma123powerSubmitted over 2 years ago

  I was find a difficult when I building this project in the footer I can't make the width :100% and I want take all the width space for the page .

  someone give me a hand thanks! have a nice day

  

  fylo-landing-page-with-two-column-layout-master

  1

  30
  

  Italo Guimarães•110

  @itsguimPosted over 2 years ago

  Hey!! Good job on this challenge! ✌️

  You could use a wrapper/container class within your footer so you can limit the expansion of your items, instead of modifying the <footer> tag itself, since the footer will naturally fit the entire width of the page if you do not limit it.

  You should also ident your markup, to prevent errors in tag closures and for better readability.

  Here are some tips to fix some issues :

  • You should increase your heading level one by one. <h1>, then <h2>, <h3>...
  • It's always recommended to nest sections inside a <main> tag.

  Regardless, you did a great job, hope you find this useful!. Happy Coding! :)

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Samuel•840

  @Samuel-AmaroSubmitted over 2 years ago

  I spent more time than I should to solve this challenge. Give me feedback on the implemented result.

  

  landing-page fylo with flex-box and css-grid and bem e rwd

  1

  40
  

  Italo Guimarães•110

  @itsguimPosted over 2 years ago

  Hey!! Nice work on completing this challenge! 👏

  Here are some tips :

  • You should increase your heading level one by one. <h1>, then <h2>...
  • It's better to use the tag <section> to nest the content inside main. <aside> is usually for side content like side navigations, etc.
  • You should only use one <nav> per page, this is usually reserved for the navigation section.
  • Anchor tags should always have discernible text.

  Regardless, you did an excellent job on this, hope you find this useful!. Happy Coding! :)

  Marked as helpful

  0