@ismaelpaul
@douglass154
Submitted
tenho duvidas em relação a propriedade position do CSS, eu utilizei ela mas não tenho certeza absoluta de como utiliza-la com maestria, tenho muita dificuldade. Também gostaria de um feedback de como eu poderia deixar meu código mais limpo, tenho certeza de que, de tudo que eu escrevi lá, dava pra retirar pelo menos 15% do código, deixar de maneira mais limpa e efetiva e continuar com os mesmos resultados ou melhores.
@ismaelpaul
Posted
Eaí Douglas, beleza?
Primeiramente, parabéns por ter completado o desafio.
Nesse caso em particular eu não usaria position, eu aplicaria flex no body para centralizar o card.
Eu aplicaria padding na classe container, assim tu garantes que o padding vai ser igual para os outros elementos <img>, <h1> e <p>. Com esse padding, não precisarás do max-width no <h1> e no <p>. A font-family poderia ser aplicada no <body>, aí não precisas repetir no <h1> and <p>. Também acho que não precisas de display:block no <h1>.
Espero ter ajudado um pouco, qualquer coisa dá um toque.
Happy coding :)
Marked as helpful
@ismaelpaul
Submitted
Hello everyone! 👋
It’s been a while since the last challenge I have completed.
For this challenge I did a Full Stack Web App, using TypeScript and React to build the front end, SASS for styling, Redux for state management, Express.js and Node.js for the RESTful back end API and MongoDB as database.
It was my first time trying TypeScript, it wasn’t so easy to wrap my head around it at the first time but now I have a better understanding of it. I am still not sure if I should create a file to declare all the interfaces and types and then export it throughout the code as needed.
I am thinking that I may not be using all the power of SASS in order to make the styling code more robust.
Although I’ve been using some semantic tags throughout the code, I think it’s not very accessible overall.
You can create your own account or you can use [email protected] as email and password as password.
Any thoughts and feedbacks on how I could improve the code are welcome and highly appreciated.
Thank you in advance and happy coding! 😊
@ismaelpaul
Posted
Unfortunately, there's a problem with the screenshot tool. It will only take the first static page as screenshot, which in my case is the login page.
@PrimeSeyi
Submitted
I dont know how this pixels thing work on html. The DOM does not reaaly reflect what i did on the CSS. I dont know why. Help would be much appreciated.
@ismaelpaul
Posted
Hi @PrimeSeyi,
Congratulations, nice job!
You don't need to use width="288px", just width="288" will be fine. And, apparently, you are not applying the font-family to your project. I can see you are using font-family: var(--base-font) but I didn't find the --base-font in your files.
Cheers,
Ismael Paul
