All comments

• 

  Geronimo2763• 10

  @Geronimo2763

  Submitted about 2 months ago

  

  Qr-code challenge

  1

  30

  

  P

  Ivan Ivanov• 20

  @isipro

  Posted about 2 months ago

  Overall a good solution, very close to the required design.

  There is a bit of a difference on the height, which can be resolved by a bit more padding/margin on the paragraph / content;

  Possible CSS Optimizations:

  • using * as a selector is effective and concise but it move expensive ( in terms of computer resources ) you can put it in the body - those styles are inherited
  • user class selectors; Using P or H3 will affect the whole site ( keep in mind for future projects, in this case this works, but you could have done it like .content p {} to be more specific)

  Code formatting

  • there are unnecessary spaces and new lines
  • you can use Prettier and Format on Save ( VS Code >> settings >> search for Formatter ; Prettier should be installed)

  Comments

  • in real projects, usually its not allowed to leave commented code ( keep in mind for the future )

  0