I add some problems with the layout, I think its my markup that keeps giving me problems. I would appreciate if someone would take a look at my markup and give me some suggestion, am I using to many div's or not enough maybe I'am not placing them around the content correctly. Thanks for the feedback.
Paras Sharma
@imparassharmaAll comments
- @MismistySubmitted 11 months ago@imparassharmaPosted 11 months ago
To be honest your approach of creating divs is not correct....You have to think how will your layout will appear before coding. You should know flex property pretty well so that you can align items easily and in more clean way. You cannot just create divs anywhere and then give them property absolute and then position them using right and left...it is not a good approach.
Like whats the point of naming a section right side and left side but in reality they are acquiring full page widths.... a more defined approach could have been like container width:100vw....then in html leftPage should be created ...and give it width of 50vw lets say,,and then rightPage with width 50vw.......in container flex direction row so that leftPage and rightPage goes next to each other....align-items center ,...justify-content :center....this is how you will have to proceed....with a particular layout in mind....
0 - @JulienLachSubmitted 11 months ago
Hello ! Juste didn't manage to set the cards columns at different positiond
@imparassharmaPosted 11 months agocard2 add this property {position: relative; top:1rem} and similarly card3 add {position: relative, top:2rem}
0 - @MacurySubmitted 11 months ago
Any ideas on how to make the main image-tint match?
@imparassharmaPosted 11 months agoadd image give it z-index 0....then create a new div same to the size of the image...and give it z-index 1 ...position it absolute so you can put it on the image div.....give background-color property in the new div which is on top of the image div and reduce its opacity by giving property opacity:0.5 ....it should work
Marked as helpful1 - @JulienLachSubmitted 11 months ago
Hello ,
Just didn't manage to set the mobile menu on top of all compenent, it pushes down the other divs when i click. But still looks fine
@imparassharmaPosted 11 months agoif you want your mobile-menu to not push the other divs when opened then you can give position : absolute to it and change right, left property to position it corectly.
0 - @Umer-KhokharSubmitted 12 months ago
Hi There 👋,
This is my solution to the challenge Newsletter sign up form with success message. I have create it using html, css and js only. If you find any of the mistake in my code or if you have recommendations for improvements, share your thoughts with me. I am always ready for your great recommendations
@imparassharmaPosted 12 months agoI looked at your code and found out that you have given position relative to the Img in the Right div when media-query is hit at 770px....By looking at that I think there is no need to give position relative to that ...it will work fine without that too
Marked as helpful0 - @wisny24Submitted 12 months ago
Can somebody help with responsiveness on phones?
@imparassharmaPosted 12 months agoYou will have to use multiple media queries according to your page. Like your page is getting messy firstly around 1450px So add one media query for 1450px and then so on check where things are getting messy and use media queries. The approach should be such that you will have to use less media queries which can be achieved if you will use proper dimension tools like %, ems, rems, vh/vw etc.
0 - @mreed4Submitted 12 months ago
Initially I wanted to avoid React and React Router, so I ended up cobbling together some vanilla JS routing. It worked, at least locally, but did not render anything when viewed on Github pages. I ended up rebuilding it using React.
The non-React attempt is the
main
branch. Github pages uses themain
branch (but doesn't actually display anything) The Netlify site uses thereact
branch.@imparassharmaPosted 12 months agoI didn't understand...are you having problem in publishing the react app in github?
0 - @Gwen-legoSubmitted 12 months ago
Hi there,
This is my first JS project, quite slow to get the brain tuned but I finally got it. I have added a red text below the submit button to guide user to pick a rating.
Let me know if you what you think, any help is appreciated.
Thank you Gwen
@imparassharmaPosted 12 months agoHey, everything good and you are going in the right direction. Also in the div content-container you have used px to give it a width and height. My suggestion is that for big divs like these you should use vh/vw as it will increase the responsiveness of your page. Try to use ems, rems for paddings too. Use px for small entities.
0 - @rsachariasSubmitted about 1 year ago
For me the most difficult part is to structure the css code. I'm not sure of how to order the rulesets in such a way that makes the most sense. If someone could have a quick look and give me some tips I'd very much appreciate it.
@imparassharmaPosted about 1 year agoEverything looks good to me! Maybe I will not be able to help you with your structural query but you are going in the right direction! Keep up the work!
1 - @marcus-hugoSubmitted almost 3 years ago
This is the most JavaScript I've written for a challenge! Should the display show NaN and Infinity or just '0.00' when the inputs aren't filled in? I think I started out with an organized approach, but by the end, felt it could be simplified! Should I have kept more variables on a global scope? Should I have had more functions?
@imparassharmaPosted almost 3 years agoTotal should give Bill amount + Tip amount
Marked as helpful0 - @buneeIsSloSubmitted about 3 years ago
😬Yikes! did this challenge take me a long time to complete... Glad to be finally done with it.
Acknowledgment
First off, I'd like to thank @tediko for writing code that's clean and comprehensive. I spent a lot of time studying his Solution to the Calculator app by FEM. This solution forced me to learn a lot of new technologies and concepts that I found extremely helpful.
Secondly, I want thank @Syafiqjos. I found a very useful way to limit user input from his Solution.
Some not so necessary Features
- Added a punny intro animation
- Flipped some colours around and added a dark theme mode
- A toggle button to switch between the two theme modes
Questions
- What tag would be more appropriate for the intro element in my markup?
- I'd like to know your thoughts on my javascript code, I found it a bit challenging to stick to the DRY principle.
- I'm fairly new to webpack, so I'd appreciate it if you could give some tips on writing a better config file.
Click here to view the Live Site
P.S. If you have any questions for me, Please feel free to message me on slack :)
@imparassharmaPosted about 3 years agoI was looking to your code and saw that you never use height. I mean how ...for the main container I have to define some height because without it then I cannot design my inner components accordingly. So can you tell me should I use vh in my body or main containers? Or how to proceed? https://imparassharma.github.io/Price-Component-Toggle-sections-/
This was the last project I did on frontendmentor but took me a lot time to adjust heights for 1440px dimension. Can you help me!
1 - @JanBlahoutSubmitted about 3 years ago
Hi,
I think the design looks good overall but I have one issue. When I switch to mobile view (iPhone X) and I click one respective link, it doesnt color the text correctly. Any ideas how to fix it ?
Also - I have tried making the text appear as a transition but I wasnt able to do it with transition all 0.3s or opacity 0 -> Opacity 1. Any tips how to do this please?
The last question would be, how to make the text more static, so it doesnt jump around when opening and closing the questions.
Thank you very much for all your feedback,
Jan
@imparassharmaPosted about 3 years agoFor making the text static you have to define the height of the container. You have also used justify-content so every time answer shows up the container adjusts its position automatically so don't use that.
Marked as helpful0