@Dnyanesh-Bachhav
Submitted
@iddahadev
@Dnyanesh-Bachhav
Submitted
@iddahadev
Posted
Does the solution include semantic HTML?
Overral it does, but a few things need to be fixed:
h2
and h4
but no h1
and h3
.h1
.h2
.span
to make the text bold should be a strong
or b
.Is it accessible, and what improvements could be made?
alt
for the image
should be human readable.scope="row"
Does the layout look good on a range of screen sizes?
Is the code well-structured, readable, and reusable?
Does the solution differ considerably from the design?
There are differences with the design such as colors, font weights and spacing, but the structure follows the design.
@xaintobas
Submitted
@iddahadev
Posted
Does the solution include semantic HTML?
Yes, you could improve it by wrapping the list of links in an ul
element.
Is it accessible, and what improvements could be made?
Yes, maybe you could add a target for the links.
Does the layout look good on a range of screen sizes? Is the code well-structured, readable, and reusable?
Yes, the only downside I see is the use of html { font-size: 62.5%; }
, this hack is not readable for other devs.
Does the solution differ considerably from the design?
Not really except some font-size
and font-weight
.
@Kissanth
Submitted
@iddahadev
Posted
Does the solution include semantic HTML?
You can improve the markup by deleting most of the div
elements. The main div
could be an article
and the rest of them could just be h1
, p
, figure
...
Is it accessible, and what improvements could be made?
You can improve accessibility by providing aria-label
when needed and use good semantic HTML for elements like time
(published date).
Does the layout look good on a range of screen sizes?
The layout has fixed size.
Is the code well-structured, readable, and reusable?
You can use CSS Variables to reuse some common styles like colors, font size and spacing.
Does the solution differ considerably from the design?
There are some elements that differ from the design like the font size of the tag, the color of the description. Good job for getting this close from the design !
@JmsLpz
Submitted
@iddahadev
Posted
The semantic could be improved, for example the div
could be an article
element.
The h3
could be a p
element. The use of br
is not necessary if the padding
and text-alignment
is correctly set.
The sizing is not correct but it is close to the design, tweaking the width of the card and the image should get you closer to the design.