feedback on my code please
Omer Mahdi
@iam-omer-mahdiAll comments
- @TonyibraSubmitted over 3 years ago@iam-omer-mahdiPosted over 3 years ago
i cant go to other countries from the border countries section . other than that good work.
0 - @sofskrbicSubmitted over 3 years ago
This is the first time I've worked with Axios and VueRouter, which was really interesting. I feel as I've learned a lot!
The challenge doesn't mention the way users should use the search bar, so I implemented one with autocomplete, which makes it easier to select the desired country.
The problem, which is immediately noticeable is load-time, due to a large amount of images. That can be fixed by showing a certain number of countries (the ones that are in viewport). I'm looking forward to improving my solution in the future, starting from this problem.
If you have any feedback, I would love to hear it!
@iam-omer-mahdiPosted over 3 years agowell very nice work sofia i really like what you did with the search bar, i dont know why but the site view only one country in my screen , and for the load time you can check my solution https://www.frontendmentor.io/solutions/vue-js-vuex-axios-gsap-sass-o46aLWzUl
other than that good work :).
0