Any feedback would be appreciated. I've been studying for a few months now and this was the first project I actually completed and coded from a blank slate that wasn't a tutorial. Super proud and its giving me the drive for more.
Hello, @tekac!
First of all, congrats on finishing your first project! :) I think you did a great job considering that it was your first project.
That being said, I noticed some things that you might consider fixing.
First off, the way your app is set up right now, you can't select a tip percentage until you've filled out the "number of people" input. This input is at the very end, so users should be able to type in the bill and a tip percentage before writing down the number of people.
Moreover, if you select a tip percentage and write in a number of people, but leave out the bill, it results in an NaN for the total value. You probably want to postpone any calculations until all inputs are filled.
In the mobile version of the app, the tip options are supposed to be in 2 columns, 3 rows, as opposed to the current 3 columns, 2 rows. Also, more padding is required for the label and the buttons. If you look carefully, the tip percentage area takes up more space than the other two input areas.
Happy coding! :)
This was my first intermediate challenge and I feel pretty good with the end result. I think im going to do more junior challenges though before doing any more intermediate stuff. comments / suggestions are welcome!
Another really fun project and I'm happy with how it turned out. My CSS is kind of all over the place so I may try to refactor it in the future. Tips/feedback always welcome.
Well done Cezar!
It looks great both on desktop and mobile.
Keep up the good work and happy coding! :)
