Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @huythonhd1999

    Posted

    Hi @TheAashay,

    Congratulation for finishing this challenge. You have done a great job. Here are some issues I found about your solution for this challenge.

    • The gap between some element is not correct with the design
    • Have a redundant link at the bottom of the card
    • Should not add padding for all <a> elements in the card: the result is when you have not hovered over the visual part of <a> element, you can able to click on the link. That's all. If there is anything wrong, please leave me a message.

    Henry

    Marked as helpful

    1
  • @huythonhd1999

    Posted

    Hi @lkwunhyo,

    Congratulation for finishing this challenge, you have done a great job. Here are some issues I found in your solution:

    • The width and heigh of the card in desktop mode are not correct with the design.
    • Missing logic when user hover on the card.

    If you have any issue about my review, please leave a message.

    Thank you. Henry.

    0
  • @Dev-Abhiram

    Submitted

    What are you most proud of, and what would you do differently next time?

    I have successfully completed my first mini project.

    What challenges did you encounter, and how did you overcome them?

    I have been always confused with grid and flexbox. I have to study more about them.

    What specific areas of your project would you like help with?

    I need help with grid and flexbox

    @huythonhd1999

    Posted

    Hi, @Dev-Abhiram

    Congratulations on finishing the first project. Overall, you have done a great job. Here are some problems I found when I looked at your page and your code:

    • Style issues:
    • The background color of the page is not correct (should be #d5e1ef).
    • There is no gray border on the card container.
    • The font size of the description is not correct (should be 22px).
    • The width and the height of the card container are not correct (should be 320x497)
    • Padding issue: the padding of the card should be 16px and you also need to add padding for the "scan" class (24px).
    • CSS file format: I think you should format your CSS file to make it more beautiful (could try some extensions in VS code like Pretier, Stylelint, ...)
    • About grid and flex-box: I think you are doing great when using the flex-box style for this challenge. You could try to use the grid system to finish this challenge as well (it could be a little bit hard when you use it for the first time).

    If there is anything wrong with my review, please leave me a message.

    Best regard,

    Henry

    0