Skip to content
OverviewSolutions
5
Comments
4
https429
@https429

All comments

  • https429•70
    @https429Posted 5 months ago

    Hey there, Boss!

    Your code is already pretty solid, but there are always ways to improve or tweak things. Here are a few suggestions:

    1. Alt Text for Images: You've got an image tag with an empty alt attribute. It's a good practice to provide descriptive alt text for images. This helps with accessibility and SEO. For example, you could use alt="Omelette".

    2. Semantic HTML: Consider using more semantic HTML tags. For example, you could use <section> tags to group related content together, like the ingredients and instructions. This can improve accessibility and SEO.

    3. CSS Variables: You're using some colors multiple times in your CSS. You could define these as CSS variables at the top of your file. This makes it easier to maintain and change your color scheme.

    4. Font Loading: You're loading two different fonts using @font-face. Consider using a service like Google Fonts or Adobe Fonts. They can handle the font loading for you and can help improve performance.

    5. Responsive Design: You've got a media query for screens larger than 768px, which is great! You might want to consider adding more breakpoints for different screen sizes to make your design even more responsive.

    6. CSS Organization: Consider organizing your CSS in a more structured way. You could group styles by component or follow a methodology like BEM or SMACSS.

    Remember, these are just suggestions. Your code is already pretty good! Keep up the good work, mate! 🚀

    0
  • ameydabhade•30
    @ameydabhadeSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    https://aesthetic-marigold-151a8c.netlify.app/

    What challenges did you encounter, and how did you overcome them?

    https://aesthetic-marigold-151a8c.netlify.app/

    What specific areas of your project would you like help with?

    https://aesthetic-marigold-151a8c.netlify.app/

    Social

    2
    https429•70
    @https429Posted 5 months ago

    It would be more accessable if you would put the Social Media Links into a <ul> <li> element. Also it would be good to put the link text into an <a> tag. Otherwise I like your approach :)

    0
  • Juned Shaikh•80
    @JUNEDSKSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    I just wanted to mention that this new card is similar to the old one, but I've added a cool new hover effect to it.

    What challenges did you encounter, and how did you overcome them?

    Nothing is challenging in this one

    What specific areas of your project would you like help with?

    less code less code less code

    Normally I have using html css and media queries

    1
    https429•70
    @https429Posted 5 months ago

    Even though your card is a big taller than the design, I like how you calculated the width of the .card class :)

    0
  • Juned Shaikh•80
    @JUNEDSKSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    Feel good to make card and next time will try to change the them

    What challenges did you encounter, and how did you overcome them?

    To make it resposive is bit challenging but i have added the media query and its worked

    What specific areas of your project would you like help with?

    Try to make less div classes name should be proper

    flex and mediaquery

    2
    https429•70
    @https429Posted 5 months ago

    Looks good :)

    Marked as helpful
    1