Skip to content
OverviewSolutions
3
Comments
3
Hien Giang
@hinn1411

All comments

  • Hien Giang•70
    @hinn1411Posted 7 months ago

    Hello Muaz, congratulations on completing the challenge! I think your work is great but it could be better by adding some improvements:

    • Firstly, your component is quite smaller than the design, I also know that we are not provided the design file in this challenge. To overcome that, you can research some tools for converting images to Figma design, for example.
    • Secondly, the hover state of the buttons is missing. The buttons should have a yellow background, black text, and a custom cursor when you hover over it. To create a custom cursor, I recommend following this article (Custom cursor with CSS). It is very helpful for this challenge.

    After all, I hope my suggestions are worth to you^^

    0
  • Hien Giang•70
    @hinn1411Posted 7 months ago

    I think your work is very good but it could be better by adding some improvements:

    • Firstly, the border-radius of the image is probably 10px. In you picture, I guess it is about 20px.
    • Secondly, when you hover over the text "HTML & CSS foundations", it should change the cursor to black cursor as the design
    • Thirdly, it is the same for the box shadow. When you hover the card component, it should be wider

    I hope that my recommendations are worth to you^^

    Marked as helpful
    1
  • Ramiro Damian Gimenez•120
    @KraudKaiserSubmitted 7 months ago
    What are you most proud of, and what would you do differently next time?

    As all things i code, my first thought always is "This is pretty easy, i should do it just for shape my skills a little better. 40 min for do it" And then, 2 hours to realize.

    Html was pretty simple, but i had to start to struggle with the css. I hate looking sizes for the images, and responsive. But with mediaqueries and % sizes, i could finally made the qr responsive.

    What challenges did you encounter, and how did you overcome them?

    The images. I really dont like them. The way of making not only fit in the container, but also make them responsive is pretty easy and the same time, tedius as nothing else.

    What specific areas of your project would you like help with?

    I need really to keep practicing css. thats all.

    Responsive QR using CSS Flexbox and mediaqueries

    1
    Hien Giang•70
    @hinn1411Posted 7 months ago
    • Firstly, It seems to me that the border-radius of your card is not right. It is maybe 20px instead
    • Secondly, the color of the content is dark blue while yours is black
    • Thirdly, the position the the card container is not center vertically, I also had the same problem!
    • Fourthly, I think the design had a shadow effect, I forgot to add the effect as well :(

    I hope that my feedback is worth to you^^

    Marked as helpful
    1