All comments

• 

  Melinda Eve• 30

  @hejira42

  Submitted 9 months ago

  Here is my first solution submitted - the QR Code project.

  I struggled with sizing/alignment of the card and image inside, as well as with padding/margins, but I think I got those down.

  I DO NOT understand why the img border-radius is not showing and would LOVE help troubleshooting this. I can't see any reason it's not applied in Chrome dev tools.

  I would also love feedback on how to improve my CSS - is it DRY? am I using best practices?

  I'm really new to learning front end (haven't started js yet) - I'm trying to spend some time with CSS to make sure I understand positioning well enough.

  Thanks in advance <3 !

  

  QR Code with Flexbox for Desktop Only

  4

  20

  

  Melinda Eve• 30

  @hejira42

  Posted 9 months ago

  Okay, awesome, I made those changes, and added gap to the card div.

  It looks better now! Thanks so much!

  0
• 

  Melinda Eve• 30

  @hejira42

  Submitted 9 months ago

  Here is my first solution submitted - the QR Code project.

  I struggled with sizing/alignment of the card and image inside, as well as with padding/margins, but I think I got those down.

  I DO NOT understand why the img border-radius is not showing and would LOVE help troubleshooting this. I can't see any reason it's not applied in Chrome dev tools.

  I would also love feedback on how to improve my CSS - is it DRY? am I using best practices?

  I'm really new to learning front end (haven't started js yet) - I'm trying to spend some time with CSS to make sure I understand positioning well enough.

  Thanks in advance <3 !

  

  QR Code with Flexbox for Desktop Only

  4

  20

  

  Melinda Eve• 30

  @hejira42

  Posted 9 months ago

  Oh, I think I figured it out! Let me edit.

  0
• 

  Melinda Eve• 30

  @hejira42

  Submitted 9 months ago

  Here is my first solution submitted - the QR Code project.

  I struggled with sizing/alignment of the card and image inside, as well as with padding/margins, but I think I got those down.

  I DO NOT understand why the img border-radius is not showing and would LOVE help troubleshooting this. I can't see any reason it's not applied in Chrome dev tools.

  I would also love feedback on how to improve my CSS - is it DRY? am I using best practices?

  I'm really new to learning front end (haven't started js yet) - I'm trying to spend some time with CSS to make sure I understand positioning well enough.

  Thanks in advance <3 !

  

  QR Code with Flexbox for Desktop Only

  4

  20

  

  Melinda Eve• 30

  @hejira42

  Posted 9 months ago

  Thanks so much for taking the time to look at this.

  I did as you suggested - moved padding to card and changed max-width on the image to 100%, but still not getting the border radius on the image?

  I've updated the code.

  1