Skip to content
OverviewSolutions
27
Comments
11
Jonel Hatwell
@hatwell-jonel

All comments

  • parkerrn9•210
    @parkerrn9Submitted about 1 year ago

    1. Responsiveness of the Design: I'd appreciate your feedback on how well the design adapts to different screen sizes and devices. Is the Stats Preview Card Component responsive and visually appealing on all screens?

    2. Logic and Code Structure: Your feedback on the organization and logic of the code is highly valuable. Are there any recommendations for enhancing the code structure and logic?

    Interactive Stats Overview Card

    1
    Jonel Hatwell•585
    @hatwell-jonelPosted about 1 year ago

    Hi, I've seen that when you put the responsiveness of the web in mobile or table size the content is overflowing to the size of the screen. additionally, On your HTML structure I think it much better if you use <main> tag than <div>. then suggest that you use BEM - Block Element Modifier for naming class.

    BEM LINK: https://getbem.com/naming/

    Marked as helpful
    1
  • Jonel Hatwell•585
    @hatwell-jonelPosted about 1 year ago

    Hi! Great work, I saw your work and I have some suggestion that can possibly improve your work.

    1. I think you should store all your image in one folder directory for much cleaner. file structure for your projects.
    2. the in testimonials class the grid-template-columns, it much better if you just use "grid-template-columns: repeat(6, auto)."
    .testimonials {
    display: grid;
    grid-template-columns: auto auto auto auto auto auto;
}

.testimonials {
    display: grid;
    grid-template-columns: repeat(6, auto);
}

    Keep coding. 👍👍👍

    Marked as helpful
    1
  • Jonel Hatwell•585
    @hatwell-jonelPosted about 1 year ago

    Hi, Great work. I saw your solution and there's some things that I think need some improvements,

    1. The whitespace when you adjustment the screen to mobile width, it is too tight or narrow.
    2. The Font size you should make it larger.
    3. The spacing in each sentence row, you need to add more space.
    4. the register word in button, you have to change the color based on the design. and add box shadow to it.
    5. the social media's button you should add more padding.

    keep coding. 👍👍👍

    Marked as helpful
    1
  • Jonel Hatwell•585
    @hatwell-jonelPosted about 1 year ago

    Good work! Keep it up.

    Marked as helpful
    0
  • Jonel Hatwell•585
    @hatwell-jonelPosted almost 3 years ago

    1. The HTML lang attribute is used to identify the language of text content on the web. This information helps search engines return language specific results, and it is also used by screen readers that switch language profiles to provide the correct accent and pronunciation. you can fix that by adding lang="en" (if your language is English) inside the html opening tag.

    2. you have one main landmark like <h1> tag to identify the main content. A main landmark provides a navigation point to the primary content of the page for users of assistive technologies. since there is no page title visible in the design, you can make the h1 not to be visible on your page.

    3. In your html code you used role="row" this landmark can be used only within the grid container.

    suggestion:

    1. change your container div to main tag. so you don't need to use role="main"

    2. get rid of role="row" if you do not want to grid your container.

    3. please click the Generate New Report button inside the Report page to know if there is still some issues in your work.

    :) :) :)

    Marked as helpful
    0
  • Jonel Hatwell•585
    @hatwell-jonelPosted almost 3 years ago

    Hey! congratulations for finishing this challenge. there are some problem the i saw in your work.

    1. when you view the the solution on the small screen device the cards is scrollable.

    2. the cards is too stretch when you view it in the portrait screen.

    3. you use <button> tag instead of <a> tag in learn more button.

    4. the accessibility and HTML issue

    suggested solution: to utilize the size of the cards you can use max-width or max-height to it. and for the <button> tag you must change it to <a> tag because when you are linking content in the website its ideal to use <a> tag than <button> tag. as for the accessibility and html issue you can check it in report page.

    articles:

    https://medium.com/design-code-repository/a-vs-button-b859547cae4d

    https://ishadeed.com/article/min-max-css/

    https://www.google.com/amp/s/www.freecodecamp.org/news/css-properties-examples/amp/

    Marked as helpful
    0
  • Jonel Hatwell•585
    @hatwell-jonelPosted almost 3 years ago

    Hi! great job for this challenge. there are some issue i saw in your HTML code. when you are button that link to the certain part of the website maybe internal or external you can use anchor tag <a> instead of <button>.

    article about using <a> as button: https://medium.com/design-code-repository/a-vs-button-b859547cae4d

    0
  • Jonel Hatwell•585
    @hatwell-jonelPosted almost 3 years ago

    Hi! congratulations for finishing this challenge. there are some issue that saw checking your html code you must use anchor tag <a> to the webpage when you are link to a certain content so you must change the "proceed to payment" button to anchor tag. also there are issues in the accessibility you can check that on the report page.

    Article on correct using of anchor tag:

    https://medium.com/design-code-repository/a-vs-button-b859547cae4d

    keep coding 👍👍

    Marked as helpful
    1
  • Jonel Hatwell•585
    @hatwell-jonelPosted almost 3 years ago

    great job! i suggest that you fix the accessibility and html issues for better user accessibility. happy coding, keep it up 👍👍👍

    1
  • Jonel Hatwell•585
    @hatwell-jonelPosted almost 3 years ago

    i will study your feedback and i saw your profile that you are from philippines, maraming salamat.

    1
  • Zayn•25
    @ZaynMuhammadSubmitted about 3 years ago

    I'd like feedback on my use of media queries and what is the best way to add them into my code that is easy to understand. I'd also like critique on my naming of CSS classes. Any other feedback is also welcome!

    Responsive landing page using Grid and SCSS

    1
    Jonel Hatwell•585
    @hatwell-jonelPosted about 3 years ago

    Hi by checking your solution their are so many issue, i think you can check the report section to view what are those. by that you can improve your coding skills. and for your CSS class naming you can check BEM naming convention for CSS.

    Keep coding! 👍

    Marked as helpful
    2